remove openssl 1.0.2 #502
Merged
remove openssl 1.0.2 #502
+72
−1,110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has all been converted to the lapin implementations.
LnL7
force-pushed
the
remove-openssl-1.0.2
branch
2 times, most recently
from
b1acfa2 to
621de56
Compare
cole-h
reviewed
May 24, 2020
| @@ -21,7 +19,7 @@ tracing-subscriber = { version = "0.2.5", features = ["json"] } | |||
| hubcaps = { git = "https://github.com/grahamc/hubcaps.git" } | |||
| #hubcaps = { path = "../../../grahamc/hubcaps/" } # for testing patches | |||
| hyper = "0.10.*" | |||
| hyper-native-tls = "0.2.4" | |||
| hyper-native-tls = "0.3.0" | |||
There was a problem hiding this comment.
For posterity's sake: CI was failing because hyper-native-tls 0.2.4 depends on native-tls 0.1.5, which depends on openssl 0.9.24, which only supports OpenSSL up to 1.1.0 (NixOS is on 1.1.1g at the time of writing).
As you can see here, the solution was to bump hyper-native-tls to 0.3.0, which depends on native-tls 0.2.4, which depends on openssl 0.10.29, which does support OpenSSL 1.1.1g.
cole-h
approved these changes
May 24, 2020
This depends on openssl 0.9.24, which only supports OpenSSL up to 1.1.0, while the default OpenSSL in nixpkgs is 1.1.1g.
With rust-amqp gone this isn't referenced anymore.
LnL7
force-pushed
the
remove-openssl-1.0.2
branch
from
621de56 to
9aecc91
Compare
|
🎉🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.