Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deepin.qcef: remove #88905

Closed
wants to merge 1 commit into from
Closed

deepin.qcef: remove #88905

wants to merge 1 commit into from

Conversation

romildo
Copy link
Contributor

@romildo romildo commented May 25, 2020 •
edited

Motivation for this change

No package in nixpkgs depends on qcef yet. It was a dependence for the forthcomming deepin-manual package. But that has changed upstream and its repository has been archived.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romildo
deepin.qcef: remove
89710a4 
No package in nixpkgs depends on qcef yet. It was a dependence for the
forthcomming deepin-manual package. But that has changed upstream.
cole-h
cole-h requested changes May 26, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

$ rg 'qcef'
pkgs/applications/audio/netease-cloud-music/default.nix
34:    deepin.qcef
71:      --set QCEF_INSTALL_PATH "${deepin.qcef}/lib/qcef"

Looks like you missed a reverse dependency.

@romildo
Copy link
Contributor Author

romildo commented May 26, 2020

Closing, because there is a package that depends on qcef.

@romildo romildo closed this May 26, 2020
@romildo romildo deleted the upd.qcef branch May 26, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romildo @cole-h