New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codechange: Reintroduce 0.4 syntax for compatibility #152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good idea IMO, breaking compatibility makes life difficult for GRF authors.
I tried this on OpenGFX+ Industries and an older version of FIRS; compared to 0.4.5 the only changes in the generated NFO are that prop13 is used instead of 0A/B/C (with the same meaning in every case I looked at), and some Action2 changes in OGFX+ caused by #118.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One copy-paste error, otherwise LGTM.
I notice there are "2 shift/reduce conflicts" in the parser debug, but those are there before this patch.
Thanks. I guess this changes the precedent for future breaking changes. :)
|
The docs should change to "deprecated" yes, perhaps with a note that the syntax was entirely removed in a range of versions. |
I think the old syntax can stay as long as it's easy to support it. Anyway with all the warnings it outputs, it should be annoying enough to incite authors to switch. |
This allows to compile FIRS master branch with many warnings.