Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: GlasgowEmbedded/glasgow
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5ec4bacba6bb
Choose a base ref
...
head repository: GlasgowEmbedded/glasgow
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b199300622ab
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on May 25, 2020

  1. applet.interface.uart: add --pulls option, for pull-up on RX. 

    Useful if the buffer driving RX line is tristated, the DUT can be
unpowered, certain multidrop scenarios, and so on.
    @whitequark
    whitequark committed May 25, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    9c10e19 View commit details

  2. README: add 1b2 Discord link.

    @whitequark
    whitequark committed May 25, 2020
    Copy the full SHA
    b199300 View commit details
Showing with 12 additions and 2 deletions.
  1. +1 −1 README.md
  2. +11 −1 software/glasgow/applet/interface/uart/__init__.py
2 changes: 1 addition & 1 deletion README.md
View file
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@

**Want one? [Subscribe here](https://mailchi.mp/44980ff6f0ab/glasgow-announcements).**

**Let's chat! Our IRC channel is [#glasgow at freenode.net](https://webchat.freenode.net/?channels=glasgow); our discussion forum is [glasgow.whitequark.org](https://glasgow.whitequark.org/).**
**Let's chat! Our IRC channel is [#glasgow at freenode.net](https://webchat.freenode.net/?channels=glasgow); our Discord channel is [#glasgow at 1BitSquared's Discord server](https://1bitsquared.com/pages/chat); our discussion forum is [glasgow.whitequark.org](https://glasgow.whitequark.org/).**

**Important note: if you are looking to assemble boards yourself, use only revC1.**

12 changes: 11 additions & 1 deletion software/glasgow/applet/interface/uart/__init__.py
View file
Original file line number Diff line number Diff line change
@@ -172,6 +172,9 @@ def build(self, target, args):
def add_run_arguments(cls, parser, access):
super().add_run_arguments(parser, access)

parser.add_argument(
"--pulls", default=False, action="store_true",
help="enable integrated pull-ups")
parser.add_argument(
"-a", "--auto-baud", default=False, action="store_true",
help="automatically estimate baud rate in response to RX errors")
@@ -188,7 +191,14 @@ async def run(self, device, args):
if args.auto_baud:
await device.write_register(self.__addr_use_auto, 1)

return await device.demultiplexer.claim_interface(self, self.mux_interface, args)
# Enable pull-ups, if requested.
# This reduces the amount of noise received on tristated lines.
pulls = set()
if args.pulls:
pulls = {args.pin_rx}

return await device.demultiplexer.claim_interface(self, self.mux_interface, args,
pull_high=pulls)

@classmethod
def add_interact_arguments(cls, parser):