Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages.redoc-cli: init at 0.9.8 #88793

Merged
merged 1 commit into from Jul 26, 2020
Merged

nodePackages.redoc-cli: init at 0.9.8 #88793

merged 1 commit into from Jul 26, 2020

Conversation

veehaitch
Copy link
Member

@veehaitch veehaitch commented May 24, 2020 •
edited

Motivation for this change

redoc-cli is ReDoc's command line interface

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veehaitch veehaitch mentioned this pull request May 28, 2020
Merged
10 tasks
@prusnak
Copy link
Member

prusnak commented May 30, 2020

Please rework your PR. It now has a merge conflict after merging #89184

@veehaitch
Copy link
Member Author

Please rework your PR. It now has a merge conflict after merging #89184

Done!

@veehaitch veehaitch requested a review from prusnak June 10, 2020 22:41
@veehaitch
Copy link
Member Author

@prusnak is there anything I can do to help getting this PR merged? Just let me know :)

@prusnak
Copy link
Member

prusnak commented Jun 18, 2020

@veehaitch I don't have merge permissions, so this needs to be merged by someone who has them.

@veehaitch
Copy link
Member Author

Maybe @calbrecht wants to take a look? :)

@veehaitch
Copy link
Member Author

Still looking forward to getting this merged :)

@calbrecht
Copy link
Member

No merge permissions either, here :)

@veehaitch
Copy link
Member Author

Maybe @infinisil? :)

@infinisil infinisil merged commit a38d8d6 into NixOS:master Jul 26, 2020
@dotlambda dotlambda mentioned this pull request Sep 13, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak Awaiting requested review from prusnak

Assignees
No one assigned
Labels
6.topic: nodejs 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@veehaitch @prusnak @calbrecht @infinisil @Janik-Haag