Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gmt: init at 6.1.0 #88837

Merged
merged 2 commits into from
Aug 24, 2020
Merged

gmt: init at 6.1.0 #88837

merged 2 commits into from
Aug 24, 2020

Conversation

tviti
Copy link
Contributor

@tviti tviti commented May 25, 2020

Motivation for this change

Adds v6.0.0 of the Generic Mapping Tools (GMT) and support coastline/basemap datasets.

Build is restricted to LGPL licensed code (although GPL and non-free are also possible).

Users interested in movie making functionality will need to also install FFmpeg (for webm and mp4 support) and/or graphicsmagick (for gif support).

ghostscript is included as a runtime dep, since I suspect most users would want this functionality out-of-the-box (w/o ghostscript, postscript is the only available output format). Not sure if it is preferable to make a wrapper v.s. using propagatedBuildInputs?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@tviti tviti force-pushed the gmt branch 3 times, most recently from 41fdae2 to 666b13b Compare May 25, 2020 01:16
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels May 25, 2020
@tviti
Copy link
Contributor Author

tviti commented Jun 9, 2020

Just wondering if there's anything I can do to help this along.

@Lassulus
Copy link
Member

Hi, sorry for the delay.
Can you rebase the commit history so you have 2 commits:

maintainers: add tviti
gmt: init at 6.1.0

cheers

@tviti
Copy link
Contributor Author

tviti commented Aug 23, 2020 via email

@Lassulus
Copy link
Member

hmm, can't figure out how to run it
I tried: gmt coast -R-90/-70/0/20 -JM6i -B -Gchocolate
got:

gmt [ERROR]: Shared GMT module not found: coast

ERROR: No module named coast was found.  This could mean one of four cases:
  1. There actually is no such module; please check your spelling.
  2. You used a modern mode module name while running in GMT classic mode.
  3. Module exists in the GMT supplemental library, but the library could not be found.
  4. Module exists in a GMT custom library, but none was specified via GMT_CUSTOM_LIBS.
Shared libraries must be in standard system paths or set via environmental parameter LD_LIBRARY_PATH.

@tviti
Copy link
Contributor Author

tviti commented Aug 24, 2020 via email

@Lassulus Lassulus changed the title gmt: init at 6.0.0 gmt: init at 6.1.0 Aug 24, 2020
@Lassulus Lassulus merged commit 76b7192 into NixOS:master Aug 24, 2020
@Lassulus
Copy link
Member

whupps, missed some name/pname issues. fixed it on master in cedef0c

@tviti
Copy link
Contributor Author

tviti commented Aug 24, 2020 via email

@Lassulus
Copy link
Member

Lassulus commented Aug 24, 2020

name gets auto generated usually out of pname and version.
so setting pname is preferred

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants