Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[haskell-updates] Add maralorn as maintainer for same haskell packages #88834

Merged
merged 2 commits into from May 25, 2020

Conversation

maralorn
Copy link
Member

Motivation for this change

I found this file to enter me as a maintainer. I just thought maybe it makes sense to enter myself into it. These are packages I care about in the sense that I actually watch the hydra status from my personal prometheus and intend to keep them working in the foreseeable future. For some of them (hlint, brittany) I haven‘t contributed anything yet, because they are just working.
Some of these libraries are very niche, others aren‘t. Not sure if it makes sense to have a maintainer for all of them.
I have no clue what the best practices here are. But I wanna help. Glad for feedback.

@maralorn maralorn changed the title haskell-updates: Add maralorn as maintainer for same haskell packages [haskell-updates] Add maralorn as maintainer for same haskell packages May 24, 2020
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maralorn Thanks for watching these packages.

I'm pretty sure this is okay, but I'm going to cc @peti so he sees this just in case.

@cdepillabout cdepillabout merged commit e5b2733 into NixOS:haskell-updates May 25, 2020
@maralorn maralorn deleted the maintainer-maralorn branch May 25, 2020 00:59
@hyperfekt
Copy link
Contributor

hyperfekt commented May 25, 2020

I think there's a problem with this, as hackage2nix appears to complain about broken packages having a maintainer (namely because of cabal-fmt).

EDIT: Now fixed by af34dbe.

@maralorn
Copy link
Member Author

maralorn commented May 25, 2020

I have opened an upstream issue to release the fixed cabal-fmt, but haven‘t gotten a reaction, yet.

EDIT: Oh, great the release happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants