New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rtl8821ce: bump to 5.5.2_34066.20200325 #88809
Conversation
Hey @hhm0, apologies for the ping, are you available for reviewing this? I'm willing to keep this package up-to-date if you don't have the bandwidth for it anymore since I have to rely on this every day. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working perfectly here 👍
after taking a second look at this: |
Thanks for pointing that out, not sure how I missed it. Rebased and squashed, should be good to go now :) |
Any updates on this? I stil get compile errors when trying to install either |
@hhm0 is listed as the maintainer but they've been unresponsive so far and I'm not aware of who to notify or what the process is to either become the maintainer of this package or just have this update merged for the time being. |
Almost forgot, while we await for the PR to be merged and backported to 20.03, you can fix this locally by doing the update in your configuration.nix file like this https://msfjarvis.dev/g/dotfiles/1e7e1306bace57267ef5085184c8fded7a1449ab |
Thanks! works perfectly :) |
Thank you! Sorry for the delay, please ping me if any PR gets stuck |
Motivation for this change
linuxPackages_latest.rtl8821ce
failed to compile due to Linux ABI changes. The fixes were already made in the source repository but the package was not updated here, causing build failures as reported in #88068. With this change, I can build and use thertl8821ce
module successfully on the Linux 5.6.13 kernel.Things done
sandbox
innix.conf
on non-NixOS linux)Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)No test existsnix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)