Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rtl8821ce: bump to 5.5.2_34066.20200325 #88809

Merged
merged 1 commit into from Jun 26, 2020
Merged

rtl8821ce: bump to 5.5.2_34066.20200325 #88809

merged 1 commit into from Jun 26, 2020

Conversation

msfjarvis
Copy link
Contributor

Motivation for this change

linuxPackages_latest.rtl8821ce failed to compile due to Linux ABI changes. The fixes were already made in the source repository but the package was not updated here, causing build failures as reported in #88068. With this change, I can build and use the rtl8821ce module successfully on the Linux 5.6.13 kernel.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests) No test exists
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@msfjarvis msfjarvis mentioned this pull request May 24, 2020
Closed
@ofborg ofborg bot requested a review from hhm0 May 24, 2020 19:45
@msfjarvis
Copy link
Contributor Author

Hey @hhm0, apologies for the ping, are you available for reviewing this? I'm willing to keep this package up-to-date if you don't have the bandwidth for it anymore since I have to rely on this every day.

IvarWithoutBones
IvarWithoutBones approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@IvarWithoutBones IvarWithoutBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working perfectly here 👍

@msfjarvis msfjarvis changed the title rtl8821ce: bump to 69765eb288a8dfad3b055b906760b53e02ab1dea rtl8821ce: bump to 5.5.2_34066.20200325 May 29, 2020
@IvarWithoutBones
Copy link
Member

IvarWithoutBones commented May 30, 2020 •
edited

after taking a second look at this:
diff looks good. though the commits should be squased, with rtl8821ce: 5.2.5_1.26055.20180108 -> 5.5.2_34066.20200325 as the message, according to the contributing guidelines

@msfjarvis
Copy link
Contributor Author

after taking a second look at this:
diff looks good. though the commits should be squased, with rtl8821ce: 5.2.5_1.26055.20180108 -> 5.5.2_34066.20200325 as the message, according to the contributing guidelines

Thanks for pointing that out, not sure how I missed it. Rebased and squashed, should be good to go now :)

@msfjarvis
rtl8821ce: 5.2.5_1.26055.20180108 -> 5.5.2_34066.20200325
6cbbe4d 
The rtl8821ce repository was updated to address for ABI changes to
Linux but our package was too far behind, resulting in breakages
as reported in #88068

Fixes: #88068
@arte921
Copy link

arte921 commented Jun 25, 2020

Any updates on this? I stil get compile errors when trying to install either linuxPackages.rtl8821ce or linuxPackages_latest.rtl8821ce, on default and latest kernels respectively.

@msfjarvis
Copy link
Contributor Author

msfjarvis commented Jun 25, 2020 •
edited

Any updates on this? I stil get compile errors when trying to install either linuxPackages.rtl8821ce or linuxPackages_latest.rtl8821ce, on default and latest kernels respectively.

@hhm0 is listed as the maintainer but they've been unresponsive so far and I'm not aware of who to notify or what the process is to either become the maintainer of this package or just have this update merged for the time being.

@msfjarvis
Copy link
Contributor Author

Almost forgot, while we await for the PR to be merged and backported to 20.03, you can fix this locally by doing the update in your configuration.nix file like this https://msfjarvis.dev/g/dotfiles/1e7e1306bace57267ef5085184c8fded7a1449ab

@arte921
Copy link

arte921 commented Jun 25, 2020

Almost forgot, while we await for the PR to be merged and backported to 20.03, you can fix this locally by doing the update in your configuration.nix file like this https://msfjarvis.dev/g/dotfiles/1e7e1306bace57267ef5085184c8fded7a1449ab

Thanks! works perfectly :)

@marsam marsam merged commit 8fc3eb8 into NixOS:master Jun 26, 2020
@marsam
Copy link
Contributor

marsam commented Jun 26, 2020

Thank you! Sorry for the delay, please ping me if any PR gets stuck
backported to 20.03 in 0ba9fdc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvarWithoutBones IvarWithoutBones IvarWithoutBones approved these changes

@hhm0 hhm0 Awaiting requested review from hhm0

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@msfjarvis @IvarWithoutBones @arte921 @marsam @Janik-Haag