extend nixpkgs update scripts to pin used versions #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 25, 2020
|
I am sorry, @hyperfekt, but I don't have any use for these pinned version files. I am in favor of implementing an option to re-produce an older build with the generator scripts, but I would like that to be implemented by parsing the commit messages, which is really simple because all the information is baked into a simple URL in there. |
|
It's not so much a matter of difficulty as one of principle. I strongly believe Git commit messages should not be a functional part of nixpkgs. |
|
If the issue lies with the time taken by the nix-prefetch-github command, I'd be more than happy to modify the PR to compute the hash from a checkout instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes sure the update scripts leave behind the necessary pins for the regenerate-hackage-packages maintainer script in nixpkgs to work.