Add support for pluggable transports #1353
Closed
+413
−224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not used by anything
To avoid circular imports while still typing both Transport and MachineState
This transport is not using any network protocol but is just issuing commands on the local machine.
The local transport should not use the ssh user for command formatting.
We need the parsed definition to be able to look at how it's configured.
cole-h
reviewed
May 25, 2020
adisbladis
force-pushed
the
pluggable-transports
branch
from
2d3a08a to
a7b8dca
Compare
adisbladis
force-pushed
the
pluggable-transports
branch
from
f32169d to
e75bbd2
Compare
pasqui23
reviewed
Dec 24, 2021
| return shlex.split(command) | ||
|
|
||
| # Don't make assumptions about remote login shell | ||
| cmd: List[str] = ["bash", "-c", command] |
There was a problem hiding this comment.
Suggested change
| cmd: List[str] = ["bash", "-c", command] | |
| cmd: List[str] = ["sh", "-c", command] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSH is not the only way to connect to machines.
I for one am using NixOps to deploy to my local machine and would like to be able to do that without going over SSH.
Another use case this opens up for is one I've been thinking a lot about but is too big for the scope of this PR, namely serial ports to deploy to embedded and air gapped machines that doesn't even have networking.
Additionally this PR contains quite a sizeable refactor to decouple command issuance from SSH which in itself makes all this effort worth it.