Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

displaycal: 3.5 -> 3.8.9.3 #88889

Merged
merged 1 commit into from Jun 4, 2020
Merged

displaycal: 3.5 -> 3.8.9.3 #88889

merged 1 commit into from Jun 4, 2020

Conversation

paperdigits
Copy link
Contributor

@paperdigits paperdigits commented May 25, 2020 •
edited

Motivation for this change

DisplayCal version 3.5 as included in NixOS 20.03 did not work. Updating the package to something more recent and testing to make sure the package works when calibration hardware is attached.

Fixes #88226

Is there some way this can be merged onto the 20.03 branch, since the package there does not function correctly?

Perhaps @calbrecht or @MarcWeber can review this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@calbrecht
Copy link
Member

First off, i do not own a calibration device. Since i was asked, i am doing a review as far as i can.
I checked it out with nixpkgs-review pr --eval local 88889, and started it in the resulting shell with displaycal.

Result of nixpkgs-review
1 package built:
displaycal

Application started without significant errors, at least did not stop execution.
ImportError: No module named faulthandler, probably when handling this warning:
Warning: org.freedesktop.DBus.Error.ServiceUnknown: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.ColorManager was not provided by any .service files: org.freedesktop.ColorManager which does not surprise since i am running on sway and do not have the x11 colord service running.

Next were some warnings about missing app icons (the one, that represent the displaycal application), but i couldn't care less about these.

I clicked around (as far as it goes without calibration device) and so far everything works.

Good job, thanks @paperdigits

@paperdigits
Copy link
Contributor Author

@calbrecht I wouldn't expect DisplayCal to work well on Wayland, since wayland doesn't have a working color management system yet :P

Thank you for your review!

@Lassulus
Copy link
Member

Lassulus commented Jun 4, 2020

seems to work.
For backporting this to 20.03 there is a section about it in the manual:
https://nixos.org/nixpkgs/manual/#submitting-changes-stable-release-branches
basically create a cherry-pick -x PR against release-20.03

@Lassulus Lassulus merged commit 872fedd into NixOS:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package displaycal broken in 20.03
3 participants
@paperdigits @calbrecht @Lassulus