Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes: 1.18.1 -> 1.18.3 #88874

Merged
merged 1 commit into from Jun 2, 2020
Merged

kubernetes: 1.18.1 -> 1.18.3 #88874

merged 1 commit into from Jun 2, 2020

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented May 25, 2020 •
edited

Motivation for this change

Update Kubernetes to the latest version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @johanot @offline

@saschagrunert
kubernetes: 1.18.1 -> 1.18.3
2bed6d5 
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert saschagrunert requested a review from srhb May 25, 2020 13:48
@ofborg ofborg bot requested review from offlinehacker and johanot May 25, 2020 13:55
@srhb
Copy link
Contributor

srhb commented May 25, 2020

Looks like the tests are broken due to some other change (flannel?)
I don't have time to look into that today, but I'll try and get it done asap. Sucks to not be sanity check this quickly.

@srhb
Copy link
Contributor

srhb commented Jun 2, 2020

While trying to fix the test issue, I rebased with nixos-unstable and was unable to reproduce the issue. Tests pass fine. Guess something was fixed in the interim. :)

@srhb srhb merged commit 15ed0ea into NixOS:master Jun 2, 2020
@saschagrunert saschagrunert deleted the kubernetes branch June 2, 2020 14:41
@saschagrunert
Copy link
Member Author

Thank you @srhb ! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb approved these changes

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@johanot johanot Awaiting requested review from johanot

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saschagrunert @srhb