Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 28667152aa63
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c640f7efd1bb
Choose a head ref
  • 1 commit
  • 1 file changed
  • 2 contributors

Commits on May 25, 2020

  1. _1password: do not strip binary on darwin(OSX) (#88091) 

    Stripping the binary on OSX causes op(1password) to fail immediately.
Setting dontStrip = true; fixes the issue.
Additionally, adding a very simple installCheck section for testing
purposes.

Co-authored-by: Corban Raun <craun@instructure.com>
    @CorbanR
    CorbanR and Corban Raun authored May 25, 2020
    Copy the full SHA
    c640f7e View commit details
Showing with 8 additions and 0 deletions.
  1. +8 −0 pkgs/applications/misc/1password/default.nix
8 changes: 8 additions & 0 deletions pkgs/applications/misc/1password/default.nix
View file
Original file line number Diff line number Diff line change
@@ -34,8 +34,16 @@ stdenv.mkDerivation rec {
install -D op $out/bin/op
'';

dontStrip = stdenv.isDarwin;

nativeBuildInputs = stdenv.lib.optionals stdenv.isLinux [ autoPatchelfHook ];

doInstallCheck = true;

installCheckPhase = ''
$out/bin/op --version
'';

meta = with stdenv.lib; {
description = "1Password command-line tool";
homepage = "https://support.1password.com/command-line/";