Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ACME maintainers team #85589

Merged
merged 5 commits into from Apr 28, 2020
Merged

Add ACME maintainers team #85589

merged 5 commits into from Apr 28, 2020

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Apr 20, 2020 •
edited

Motivation for this change

Add a maintainers team for ACME, per #83474 (comment).

To avoid having a huge team that gets pinged on every PR, I kept it to people who have recently made substantial/multiple changes to the ACME modules, erring on the side of leaving people out, but without any intent to make a value judgement on their contributions. If you're in the list but don't want to actively review ACME PRs, or are missing but want to be added, please let me know!

cc (on the list, but might not want to be) @aanderse @andrew-d @arianvp @flokli @m1cr0man
cc (not on the list, but might want to be) @abbradar @fpletz @globin @Mic92 @mweinelt (...insert yourself here?)
cc (not in lib.maintainers) @immae

cc @grahamc; would it be possible to have an @NixOS/acme-maintainers team generated from this for ccs? I'm not sure if ofborg supports automatically pinging maintainers of a test/module, and having automatically generated *-maintainers GitHub teams seems like something that would be useful in general.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@emilazy
Copy link
Member Author

emilazy commented Apr 20, 2020

@GrahamcOfBorg build lego pebble
@GrahamcOfBorg test acme

@immae
Copy link
Contributor

immae commented Apr 20, 2020 •
edited

I’m okay with being added to maintainer’s list. Here is my details for lib.maintainers:

  immae = {
    email = "projects+nixpkgs _ mail.immae.eu";
    github = "immae";
    githubId = 510202;
    name = "Immae";
  };

@andrew-d
Copy link
Contributor

I'm okay with being on the maintainers list 👍

@goblin
Copy link

goblin commented Apr 20, 2020

cc (not on the list, but might want to be) [...] @goblin [...] (...insert yourself here?)

I don't think I made any significant contributions to nixpkgs, especially not recently. This may be a typo.

@emilazy
Copy link
Member Author

emilazy commented Apr 20, 2020

Oops, sorry; meant @globin :)

@emilazy
Copy link
Member Author

emilazy commented Apr 20, 2020

(Will give some time for more people to respond before rebasing with list changes.)

@worldofpeace
Copy link
Contributor

cc @grahamc; would it be possible to have an @NixOS/acme-maintainers team generated from this for ccs? I'm not sure if ofborg supports automatically pinging maintainers of a test/module, and having automatically generated *-maintainers GitHub teams seems like something that would be useful in general.

The PR by @jtojnar that added maintainer teams has an experiment at NixOS/ofborg#421, but something like that was for sure planned/we were interested in doing this. I asked graham before and I don't believe meta.maintainers will be automatically pinged in modules. Can't remember about nixos tests.

@mweinelt
Copy link
Member

Thanks, I think I'm only opportunistically contributing to the ACME ecosystem in nixpkgs.

@m1cr0man
Copy link
Contributor

I'm happy to be on the list :) (Although it seems I need to improve my mail filters!)

@worldofpeace
Copy link
Contributor

@emilazy Is this PR ready for merge?

@arianvp
Copy link
Member

arianvp commented Apr 28, 2020

looks good to me. happy to be on the list

@worldofpeace worldofpeace merged commit 10bf212 into NixOS:master Apr 28, 2020
@emilazy
Copy link
Member Author

emilazy commented Apr 29, 2020

@worldofpeace Thanks! Do you know what would be required to get a @NixOS/acme-maintainers team set up manually with the members of this for cc convenience? Seems like we're likely to need to touch ACME stuff again before NixOS/ofborg#421 is merged.

@immae Sorry for not getting around to rebasing with you, feel free to add yourself whenever you send a PR touching ACME stuff again!

@emilazy emilazy deleted the add-acme-maintainers-team branch April 29, 2020 20:53
@worldofpeace
Copy link
Contributor

@worldofpeace Thanks! Do you know what would be required to get a @NixOS/acme-maintainers team set up manually with the members of this for cc convenience? Seems like we're likely to need to touch ACME stuff again before NixOS/ofborg#421 is merged.

Done in https://github.com/orgs/NixOS/teams/acme. I invited everyone in the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@emilazy @immae @andrew-d @goblin @worldofpeace @mweinelt @m1cr0man @arianvp