Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.bap: 1.6.0 -> 2.0.0 #85588

Merged
merged 1 commit into from Aug 14, 2020
Merged

ocamlPackages.bap: 1.6.0 -> 2.0.0 #85588

merged 1 commit into from Aug 14, 2020

Conversation

maurer
Copy link
Member

@maurer maurer commented Apr 20, 2020

Also roll libbap forwards, as it does not build against the new bap.

Motivation for this change

Update packages to new version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@maurer
ocamlPackages.bap: 1.6.0 -> 2.0.0
eaed1fd 
Also roll libbap forwards, as it does not build against the new bap.
@cole-h
Copy link
Member

cole-h commented Apr 20, 2020

@ofborg eval

Dunno why the bot hasn't kicked off yet. Let's see if a gentle nudge helps.

@vbgl vbgl merged commit 1c243af into NixOS:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maurer @cole-h @vbgl