Skip to content

mednafen: Add alsaLib to get ALSA audio output #85506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2020
Merged

mednafen: Add alsaLib to get ALSA audio output #85506

merged 1 commit into from
Apr 23, 2020
+2 −1

Conversation

DamienCassou
Copy link
Contributor

Motivation for this change

Sound in mednafen won't work on a standard Linux installation (including nixos with hardware.pulseautio.enable = true).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot requested a review from AndersonTorres April 18, 2020 18:46
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Apr 18, 2020
@DamienCassou DamienCassou force-pushed the damien/mednafen-with-alsa branch 2 times, most recently from f9bdd3c to 322c55c Compare April 22, 2020 16:11
@DamienCassou
mednafen: Add alsaLib to get ALSA audio output

Verified

This commit was signed with the committer’s verified signature.
DamienCassou Damien Cassou
GPG key ID: B68746238E59B548
Verified
Learn about vigilant mode
a3f35c0
@DamienCassou DamienCassou force-pushed the damien/mednafen-with-alsa branch from 322c55c to a3f35c0 Compare April 23, 2020 17:48
@Mic92 Mic92 merged commit 189d148 into NixOS:master Apr 23, 2020
@DamienCassou DamienCassou deleted the damien/mednafen-with-alsa branch April 24, 2020 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DamienCassou @Mic92