waybar: optionally wrap mediaplayer.py #85507
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/145 |
|
I made the change. Thanks. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/150 |
| ] ++ stdenv.lib.optional withMediaPlayer playerctl; | ||
|
|
||
| propagatedBuildInputs = stdenv.lib.optionals withMediaPlayer [ | ||
| gobject-introspection |
There was a problem hiding this comment.
this should be native, and you'll need to set strictDeps = false; for it's setup hook to work properly.
|
|
||
| propagatedBuildInputs = stdenv.lib.optionals withMediaPlayer [ | ||
| gobject-introspection | ||
| python38Packages.pygobject3 | ||
| ]; | ||
|
|
||
| buildInputs = with stdenv.lib; |
There was a problem hiding this comment.
you need to conditionally add glib because it uses it via gobject-introspection https://github.com/Alexays/Waybar/blob/master/resources/custom_modules/mediaplayer.py#L9
not sure where the playerctl module comes from
|
I made the changes. Thank you very much for your time. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/158 |
bbigras
requested review from
adisbladis,
alyssais,
edolstra,
edwtjo,
Ericson2314,
FRidh,
infinisil,
joachifm and
jtojnar
as code owners
bbigras
requested review from
matthewbauer,
nbp,
peti,
Profpatsch,
rycee,
tfc,
thoughtpolice,
ttuegel and
WilliButz
as code owners
|
holy shit. I'm sorry everyone. I clearly didn't push the right thing. |
Motivation for this change
waybar has a
mediaplayer.pyscript that uses mpris to show the current song.Things done
Quite a package closure size increase.
No idea if I should use
preFixupor another phase.sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)/nix/store/igjl73fjbg42hdk4di4bpjb6gypjx3cl-waybar-0.9.2 202.7M
/nix/store/sknk7z9mqbfsx25ijcvj23aw5c93fdwj-waybar-0.9.2 856.9M