Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i3lock-color: 2.12.c.1 -> 2.12.c.2 #85525

Closed
wants to merge 1 commit into from
Closed

i3lock-color: 2.12.c.1 -> 2.12.c.2 #85525

wants to merge 1 commit into from

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Apr 19, 2020

Mark is_release to be yes so ASAN isn't used

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eadwu
i3lock-color: 2.12.c.1 -> 2.12.c.2
23f1895 
Mark is_release to be yes so ASAN isn't used
@ofborg ofborg bot requested a review from malyn April 19, 2020 00:37
@drewrisinger
Copy link
Contributor

What is ASAN?

Builds locally with nixpkgs-review pr 85525:

https://github.com/NixOS/nixpkgs/pull/85525
3 package built:
betterlockscreen i3lock-color i3lock-fancy

@GrahamcOfBorg build i3lock-color

@eadwu
Copy link
Member Author

eadwu commented Apr 28, 2020

https://clang.llvm.org/docs/AddressSanitizer.html
More of something used in development I believe.

drewrisinger
drewrisinger approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See prev comment for build.

  • Diff LGTM
  • Builds OK
  • Tested locally

@eadwu
Copy link
Member Author

eadwu commented May 21, 2020

#88149

I'll just keep the ASAN override locally since it seems like it isn't a problem as long as someone doesn't use a hardened malloc.

@eadwu eadwu closed this May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger approved these changes

@malyn malyn Awaiting requested review from malyn

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eadwu @drewrisinger