edk2: Support build on macOS #85603
Merged
edk2: Support build on macOS #85603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to use OVMF firmware with e.g. qemu on macOS, these packages needed to be made macOS ready. This meant choosing the clang build in this case, because it is the only one working on macOS. Unfortunately, just using clang on all platforms doesn't work because there are hardcoded assumptions in the edk2 build system.
tfc
requested review from
abbradar,
Ericson2314 and
dezgeg
and removed request for
abbradar
tfc
approved these changes
Apr 20, 2020
|
Tested this on Mac, LGTM. |
Mic92
reviewed
Apr 20, 2020
Mic92
reviewed
Apr 20, 2020
Mic92
reviewed
Apr 20, 2020
Mic92
reviewed
Apr 20, 2020
Mic92
reviewed
Apr 20, 2020
ofborg
bot
added
6.topic: darwin
|
@Mic92 can you have another look please? |
Mic92
reviewed
Apr 28, 2020
Mic92
reviewed
Apr 28, 2020
|
@GrahamcOfBorg build edk2 |
prusnak
requested changes
May 2, 2020
| @@ -57,6 +57,6 @@ edk2.mkDerivation projectDscPath { | |||
| description = "Sample UEFI firmware for QEMU and KVM"; | |||
| homepage = https://github.com/tianocore/tianocore.github.io/wiki/OVMF; | |||
There was a problem hiding this comment.
Please put the URL in the homepage field into quotes (RFC45).
| @@ -38,15 +63,15 @@ edk2 = stdenv.mkDerivation { | |||
|
|
|||
| enableParallelBuilding = true; | |||
|
|
|||
| meta = with stdenv.lib; { | |||
| meta = with lib; { | |||
| description = "Intel EFI development kit"; | |||
| homepage = https://sourceforge.net/projects/edk2/; | |||
There was a problem hiding this comment.
Please put the URL in the homepage field into quotes (RFC45).
|
Result of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Booting qemu tests with OVMF firmware on macOS requires the firmware files provided by these packages. With this change, the package builds out of the box. My first attempt was to use clang everywhere, but unfortunately, there are some assumptions in the edk2 build system that caused the clang build on Linux to fail.
Note: There seems to be an issue with temporary directories (AF_UNIX path name too long) on macOS, I had to run
TMPDIR=/tmp nix-build default.nix -A OVMF.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)