PHP maintainer team #85575
Merged
PHP maintainer team #85575
+87
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: nixos
Ma27
approved these changes
Apr 19, 2020
jtojnar
reviewed
Apr 19, 2020
aanderse
approved these changes
Apr 19, 2020
|
@jtojnar I requested a review of you because I know you're active in the ecosystem as well, but for some reason I didn't add you to the team. Do you want in on the maintainer team? |
talyz
approved these changes
Apr 20, 2020
|
I do not see myself actively maintaining these parts so I think I would prefer remaining an outside observer. |
Also passthrough the meta of the package to have description, homepage, license, maintainers and other metadata passed through to the commonly used attribute.
etu
force-pushed
the
php-maintainer-team
branch
from
13030c2 to
4b43622
Compare
|
@etu is there any reason this isn't merged yet? :) |
|
@Ma27 Yes, one reason. It would create horrible conflicts with the PHP refactor by @talyz. So I would rather rebase this one than he rebasing his changes. But now I merged this (because I thought I was on his PR for a minute there) and then reverted this one to be able to merge his one without conflicts and will now rebase this one and make a new PR of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Since we now have support for maintainer teams I thought that we should have one for PHP. It's a big ecosystem used by many after all.
So I took the liberty to add a bunch of people and I will request a review from these people, and I won't merge them as part of the maintainer team unless they approve this PR.
These people are added to the maintainer team: @aanderse @globin @Ma27 @talyz
If you don't want to be on the maintainer team, please leave a note and I'll update the PR.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)