Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openjk: use gcc9 #85538

Merged
merged 1 commit into from Apr 19, 2020
Merged

openjk: use gcc9 #85538

merged 1 commit into from Apr 19, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 19, 2020 •
edited by ghost

Motivation for this change

There is no need to stick to gcc8 since gcc 9.3.0 is landed in nixpkgs JACoders/OpenJK#1021 (comment)
There is no segfault with gcc 9.3.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak
Copy link
Member

prusnak commented Apr 19, 2020

Most probably fixes #85523

@prusnak prusnak mentioned this pull request Apr 19, 2020
Closed
@aanderse aanderse merged commit a0e496a into NixOS:master Apr 19, 2020
@ghost
Copy link
Author

ghost commented Apr 19, 2020

@prusnak @aanderse Thanks!

@ghost ghost deleted the openjk branch April 19, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prusnak @aanderse