Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vollkorn: init at 4.105 #83028

Closed
wants to merge 1 commit into from
Closed

vollkorn: init at 4.105 #83028

wants to merge 1 commit into from

Conversation

rasendubi
Copy link
Member

Motivation for this change

I want to use this font.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

puzzlewolf
puzzlewolf suggested changes Mar 28, 2020
View reviewed changes
Copy link
Contributor

@puzzlewolf puzzlewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed points
  • package path fits guidelines
  • package name fits guidelines
  • package version fits guidelines
  • package build on x86_64-linux
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.platforms is set
  • meta.maintainers is set
  • source is fetched using the appropriate function
  • phases are respected

pkgs/data/fonts/vollkorn/default.nix Outdated
Comment on lines 9 to 10
downloadToTemp = true;
recursiveHash = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
downloadToTemp = true;
recursiveHash = true;

No need to specify those, they are set by default in fetchzip.

pkgs/data/fonts/vollkorn/default.nix

sha256 = "0pvy72v8wsnghww67vy8i1wyk4nikyh8pylk7gjp21ar754sih3k";

meta = with lib; {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A package needs a maintainer :)

Please add yourself (as you created the package), and also add yourself to maintainers/maintainer-list.nix in a separate commit.

@rasendubi
Copy link
Member Author

@puzzlewolf updated, thanks!

@rasendubi
Copy link
Member Author

@GrahamcOfBorg eval

puzzlewolf
puzzlewolf approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@puzzlewolf puzzlewolf left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

puzzlewolf
puzzlewolf suggested changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@puzzlewolf puzzlewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I just noticed something:

$ ls share/doc/vollkorn-4.105/ -a
.  ..  ._Fontlog.txt  Fontlog.txt  ._OFL-FAQ.txt  OFL-FAQ.txt  OFL.txt

I don't think we want ._Fontlog.txt and ._OFL-FAQ.txt:

$ file -s share/doc/vollkorn-4.105/._*
share/doc/vollkorn-4.105/._Fontlog.txt: AppleDouble encoded Macintosh file
share/doc/vollkorn-4.105/._OFL-FAQ.txt: AppleDouble encoded Macintosh file

Bonus points for reporting upstream, I doubt they should be in the release .zip :)

@puzzlewolf puzzlewolf mentioned this pull request Apr 15, 2020
Merged
10 tasks
@rasendubi
Copy link
Member Author

We need to re-package vollkorn to use mkDerivation instead of fetchzip directly (as pointed in #83537).

I stopped using this font so I have little motivation to do that and I'm closing this PR.

If anyone wants vollkorn packaged for nixpkgs, just ping me here and I'll do that.

@rasendubi rasendubi closed this Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puzzlewolf puzzlewolf puzzlewolf requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rasendubi @puzzlewolf