Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tmuxPlugins.fingers: init at 1.0.1 #85529

Merged
merged 1 commit into from Jun 24, 2020
Merged

tmuxPlugins.fingers: init at 1.0.1 #85529

merged 1 commit into from Jun 24, 2020

Conversation

ceedubs
Copy link
Contributor

@ceedubs ceedubs commented Apr 19, 2020

Motivation for this change

tmux-fingers provides copy pasting with vimium/vimperator like hints.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ceedubs ceedubs closed this Apr 19, 2020
@ceedubs ceedubs reopened this Apr 19, 2020
drewrisinger
drewrisinger suggested changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change checked-out rev

Built locally with nixpkgs-review, didn't test beyond that.

pkgs/misc/tmux-plugins/default.nix Outdated Show resolved Hide resolved
@drewrisinger
Copy link
Contributor

drewrisinger commented Apr 28, 2020 •
edited

These commits need squashed down before merging. And to make OfBorg happy, you should change title to something like tmuxplugin.tmux-fingers (sorry, I don't know the exact prefix, it's however you would build it via nix-build -A ...).
This currently fails to evaluate because you haven't defined the variable version in the proper scope. You need to make the derivation a recursive set, like in
https://github.com/NixOS/nixpkgs/blob/7e9f153d6f06ac02f01fe12438d3544214f7895b/pkgs/misc/tmux-plugins/default.nix#L101

@ceedubs @drewrisinger
tmuxPlugins.fingers: init at 1.0.1
d95ac63 
[tmux-fingers](https://github.com/Morantron/tmux-fingers) provides copy pasting with vimium/vimperator like hints.

Use tag for tmux-fingers rev based on PR feedback

Co-Authored-By: Drew <drewrisinger@users.noreply.github.com>
@ceedubs
Copy link
Contributor Author

ceedubs commented Apr 29, 2020

Thank you for the helpful review, @drewrisinger! Hopefully I've resolved all of the issues.

@ceedubs ceedubs changed the title tmux-fingers: init at 1.0.1 tmuxPlugins.fingers: init at 1.0.1 Apr 29, 2020
@drewrisinger
Copy link
Contributor

drewrisinger commented Apr 29, 2020 •
edited

Leaving it as tmuxPlugs.tmux-fingers is fine with me if you'd like. I'm not familiar with the conventions, basically whatever name will make it easier to find for users.

@GrahamcOfBorg build tmuxPlugins.fingers

@ceedubs
Copy link
Contributor Author

ceedubs commented Apr 29, 2020

@drewrisinger taking a look through https://github.com/NixOS/nixpkgs/blob/master/pkgs/misc/tmux-plugins/default.nix it looks like the tmux plugins generally don't have a tmux- prefix, so I think that in its current form it's matching the convention.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/172

jonringer
jonringer approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

https://github.com/NixOS/nixpkgs/pull/85529
1 package built:
tmuxPlugins.fingers

@jonringer jonringer merged commit 08a69fb into NixOS:master Jun 24, 2020
@ceedubs ceedubs deleted the init-tmux-fingers branch August 13, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@drewrisinger drewrisinger drewrisinger approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ceedubs @drewrisinger @nixos-discourse @jonringer