forked-daapd: init at 27.2 #85550
forked-daapd: init at 27.2 #85550
Conversation
|
This PR has way too many options. Check out NixOS/rfcs#42 |
Unfortunately I found the RFC repo only after opening this PR. I‘ll fix and update this soon. |
flyfloh
force-pushed
the
forked-daapd
branch
3 times, most recently
from
dc69dbe
to
24f565f
Compare
|
I've now:
Unfortunately checks are failing in the pipeline. Can someone help me understand what it is that fails? |
flyfloh
force-pushed
the
forked-daapd
branch
2 times, most recently
from
ea5f9bc
to
024c56c
Compare
|
I found the problem and updated the MR. This also now uses the latest version of |
flyfloh
force-pushed
the
forked-daapd
branch
from
dc7cbf8
to
7eacbbf
Compare
| @@ -0,0 +1,44 @@ | |||
| import ./make-test-python.nix ({ pkgs, ... }: | |||
There was a problem hiding this comment.
I'm not sure whether this is something that needs fixing:
https://github.com/NixOS/nixpkgs/pull/85550/checks?check_run_id=1432921834
@tfc Any idea?
There was a problem hiding this comment.
log says
gcc: error: unrecognized command line option '-m64'
make[1]: *** [Makefile:453: antlr3baserecognizer.lo] Error 1
make[1]: Leaving directory '/build/libantlr3c-3.4'
make: *** [Makefile:308: all] Error 2
error: --- Error --- nix-daemon
builder for '/nix/store/g93kbabwq81cx2r7hcpbvc7cy69qc0h4-libantlr3c-3.4.drv' failed with exit code 2; last 10 log lines:
building
build flags: SHELL=/nix/store/93xwsgby6fchr8a58ckgcm2lf4nkv6fl-bash-4.4-p23/bin/bash
make all-am
make[1]: Entering directory '/build/libantlr3c-3.4'
/nix/store/93xwsgby6fchr8a58ckgcm2lf4nkv6fl-bash-4.4-p23/bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -Iinclude -m64 -O2 -Wall -c -o antlr3baserecognizer.lo `test -f 'src/antlr3baserecognizer.c' || echo './'`src/antlr3baserecognizer.c
libtool: compile: gcc -DHAVE_CONFIG_H -I. -Iinclude -m64 -O2 -Wall -c src/antlr3baserecognizer.c -fPIC -DPIC -o .libs/antlr3baserecognizer.o
gcc: error: unrecognized command line option '-m64'
make[1]: *** [Makefile:453: antlr3baserecognizer.lo] Error 1
make[1]: Leaving directory '/build/libantlr3c-3.4'
make: *** [Makefile:308: all] Error 2
Seems like it's not the test but libantlr's build process
| let | ||
| cfg = config.services.forked-daapd; | ||
|
|
||
| configPrimitives = with types; (nullOr (either (either (either bool int) str) path)); |
There was a problem hiding this comment.
Don't we have something that roughly works like
nullOr (oneOf [bool int str path])In the libs? This could be a "fold either".
| home = mkOption { | ||
| type = types.path; | ||
| default = "/var/lib/forked-daapd"; | ||
| description = "The directory where forked-daapd will create files. Make sure it is writable."; |
There was a problem hiding this comment.
It would be helpful if the systemd execution script would check that and give an actionable error msg
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
NixOS is missing a package for forked-daapd, which is a DAAP (iTunes) and MPD media server with support for AirPlay devices (multiroom), Apple Remote (and compatibles), Chromecast, Spotify and internet radio.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)