Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libqmi: enableParallelBuilding #85551

Merged
merged 1 commit into from Apr 19, 2020
Merged

libqmi: enableParallelBuilding #85551

merged 1 commit into from Apr 19, 2020

Conversation

alyssais
Copy link
Member

Works fine for me with -j48.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
libqmi: enableParallelBuilding
e131994 
Works fine for me with -j48.
@worldofpeace worldofpeace self-requested a review April 19, 2020 16:23
@worldofpeace
Copy link
Contributor

Same as #85549 (comment)

worldofpeace
worldofpeace approved these changes Apr 19, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem

@alyssais alyssais merged commit ec2710b into NixOS:master Apr 19, 2020
@alyssais alyssais deleted the libqmi branch April 19, 2020 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alyssais @worldofpeace