Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modemmanager: enableParallelBuilding #85549

Merged
merged 1 commit into from Apr 19, 2020
Merged

modemmanager: enableParallelBuilding #85549

merged 1 commit into from Apr 19, 2020

Conversation

alyssais
Copy link
Member

Seems to work fine for me at -j48.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
modemmanager: enableParallelBuilding
2fc3156 
Seems to work fine for me at -j48.
nh2
nh2 approved these changes Apr 19, 2020
View reviewed changes
Copy link
Contributor

@nh2 nh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI it does mass-rebuild (only) the Gnome desktop.

@worldofpeace worldofpeace self-requested a review April 19, 2020 16:23
@worldofpeace
Copy link
Contributor

@alyssais I typically put these in staging.

@worldofpeace worldofpeace mentioned this pull request Apr 19, 2020
Merged
10 tasks
worldofpeace
worldofpeace approved these changes Apr 19, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem

@alyssais alyssais merged commit a72c5b5 into NixOS:master Apr 19, 2020
@alyssais alyssais deleted the modemmanager branch April 19, 2020 22:35
@alyssais
Copy link
Member Author

@worldofpeace seems a bit small for staging, no? Do you just put any package with dependents into staging?

@worldofpeace
Copy link
Contributor

@worldofpeace seems a bit small for staging, no? Do you just put any package with dependents into staging?

I'd put networkmanager updates in staging and I believe this should rebuild that. Also rebuilding all of gnome is taxing, and that's enough for staging to be useful (to not slow dev on master) I believe even the heuristic that nixpkgs-updates submits PRs for this package also targets staging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

@nh2 nh2 nh2 approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alyssais @worldofpeace @Mic92 @nh2