Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: add git to extraPath #85514

Merged
merged 1 commit into from Apr 19, 2020
Merged

docker: add git to extraPath #85514

merged 1 commit into from Apr 19, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 18, 2020

When building a docker container from git, docker was missing the git
binary in $PATH.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost requested a review from periklis April 18, 2020 19:43
docker: add git to extraPath
08d83c1 
When building a docker container from git, docker was missing the git
binary in $PATH.
@offlinehacker offlinehacker merged commit bc0e5f8 into NixOS:master Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@periklis periklis Awaiting requested review from periklis

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

@tailhook tailhook Awaiting requested review from tailhook

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@offlinehacker