Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

laminar: init at 0.8 #85595

Merged
merged 1 commit into from Aug 27, 2020
Merged

laminar: init at 0.8 #85595

merged 1 commit into from Aug 27, 2020

Conversation

KAction
Copy link
Contributor

@KAction KAction commented Apr 20, 2020

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cole-h
Copy link
Member

cole-h commented Apr 20, 2020

@ofborg eval

Something broke somewhere. Time to kick off evals manually. (Sorry.)

@KAction
Copy link
Contributor Author

KAction commented Apr 26, 2020

Should I do something about?

@KAction
Copy link
Contributor Author

KAction commented Aug 23, 2020

Ping?

@Lassulus
Copy link
Member

hey, sorry for the delay. package look good to me, the JS/CSS import are kinda uncommon, and not easily overrideable this way. But that shouldn't be a big problem

@Lassulus Lassulus merged commit f88ab58 into NixOS:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KAction @cole-h @Lassulus