treewide: replace bazaar with breezy #85539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prusnak
reviewed
Apr 19, 2020
rnhmjoj
force-pushed
the
breezy
branch
2 times, most recently
from
7967049
to
fadb56c
Compare
ofborg
bot
requested review from
jtojnar,
dfoxfranke,
Ma27,
bennofs and
sivteck
jtojnar
approved these changes
Apr 22, 2020
makefu
approved these changes
May 4, 2020
There was a problem hiding this comment.
I approve of this PR, less python2-only packages is a plus.
csv2svn only uses bazaar as checkInput not much to stop working here as long as the tests succeed.
It would probably a good idea to add the deprecation notice into the release-notes and maybe even add some documentation to the manual, however i would not even know where to put it
Right, I now mentioned the change in the release notes. Thank you. |
Ma27
approved these changes
May 6, 2020
Bazaar is deprecated in favour of Breezy, which is backward compatible Python 3 fork of the original VCS.
|
Rebased. I think it has received enough feedback, now: I'm going to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fix #80740
Things done
./result/bin/)nix-review report
Result of
nixpkgs-review19 package built:
closure size increase
As @jtojnar noticed, breezy constitues a large increase in closure size due to an issue in
python3Packages.secretstorage. The solution is trivial but I decided to deal with this in another PR not to mix up the two changes in the results of nix-review.edit: Fixed in #85571