Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libreoffice: fix and update #85572

Merged
merged 2 commits into from Apr 20, 2020
Merged

libreoffice: fix and update #85572

merged 2 commits into from Apr 20, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Apr 19, 2020 •
edited

Motivation for this change

LibreOffice doesn't compile on master right now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from 7c6f434c April 19, 2020 17:38
@ajs124
Copy link
Member Author

ajs124 commented Apr 19, 2020

built still successfully 🎉

@ajs124
Copy link
Member Author

ajs124 commented Apr 19, 2020

and fresh as well 🥳

both timed out after an hour on ofBorg, though.

cc @jtojnar @7c6f434c

@ajs124 ajs124 marked this pull request as ready for review April 19, 2020 19:12
@7c6f434c 7c6f434c merged commit b22ec9c into NixOS:master Apr 20, 2020
@ajs124 ajs124 deleted the libreoffice branch April 20, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajs124 @7c6f434c