Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional docs for doJailbreak #85537

Merged
merged 1 commit into from Apr 19, 2020
Merged

Additional docs for doJailbreak #85537

merged 1 commit into from Apr 19, 2020

Conversation

asheshambasta
Copy link
Contributor

@asheshambasta asheshambasta commented Apr 19, 2020 •
edited

Motivation for this change

Yesterday with @infinisil on #nixos, he pointed me to: NixOS/jailbreak-cabal#7 after a good deal of time wrangling through a package to make it work.
The nix-build -K command, is very handy for debugging things like these, again I learnt from infinisil.
And after much experimenting and looking through, it turned out that jailbreaking wasn't working as expected, and its documentation could point it out to avoid future confusion.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@asheshambasta
Additional docs for doJailbreak
2803da7 
Yesterday with @infinisil on #nixos, he pointed me to: NixOS/jailbreak-cabal#7 after a good deal of time wrangling through a package to make it work. 
The `nix-build -K` command, is very handy for debugging things like these, again I learnt from infinisil. 
And after much experimenting and looking through, it turned out that jailbreaking wasn't working as expected, and its documentation could point it out to avoid future confusion.
@asheshambasta asheshambasta mentioned this pull request Apr 19, 2020
Closed
10 tasks
@cdepillabout
Copy link
Member

Looks good, thanks!

@cdepillabout cdepillabout merged commit 536c1c6 into NixOS:haskell-updates Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asheshambasta @cdepillabout