Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: a88d17bc6934
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: ab0da25762b9
Choose a head ref
  • 7 commits
  • 11 files changed
  • 3 contributors

Commits on Apr 18, 2020

  1. pebble: v2.2.2 -> v2.3.0

    Also add myself to maintainers and correct meta.homepage.
    emilazy committed Apr 18, 2020
    Copy the full SHA
    6285d5e View commit details
    Browse the repository at this point in the history
  2. nixos/tests/acme: don't restrict to x86_64

    This was added in aade4e5, but the
    implementation of the ACME module has been entirely rewritten since
    then, and the test seems to run fine on AArch64.
    emilazy committed Apr 18, 2020
    Copy the full SHA
    352e30d View commit details
    Browse the repository at this point in the history
  3. nixos/tests/acme: use *.test domains

    Shimming out the Let's Encrypt domain name to reuse client configuration
    doesn't work properly (Pebble uses different endpoint URL formats), is
    recommended against by upstream,[1] and is unnecessary now that the ACME
    module supports specifying an ACME server. This commit changes the tests
    to use the domain name acme.test instead, and renames the letsencrypt
    node to acme to reflect that it has nothing to do with the ACME server
    that Let's Encrypt runs. The imports are renamed for clarity:
    
    * nixos/tests/common/{letsencrypt => acme}/{common.nix => client}
    * nixos/tests/common/{letsencrypt => acme}/{default.nix => server}
    
    The test's other domain names are also adjusted to use *.test for
    consistency (and to avoid misuse of non-reserved domain names such
    as standalone.com).
    
    [1] letsencrypt/pebble#283 (comment)
    
    Co-authored-by: Yegor Timoshenko <yegortimoshenko@riseup.net>
    emilazy and lukateras committed Apr 18, 2020
    Copy the full SHA
    d0f04c1 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    695fd78 View commit details
    Browse the repository at this point in the history
  5. nixos/tests/common/acme: enable Pebble strict mode

    This lets us get early warning about any bugs or backwards-compatibility
    hazards in lego.
    
    Pebble will default to this in the future, but doesn't currently;
    see https://github.com/letsencrypt/pebble/blob/v2.3.0/README.md#strict-mode.
    emilazy committed Apr 18, 2020
    Copy the full SHA
    e6d5e83 View commit details
    Browse the repository at this point in the history
  6. nixos/tests/common/acme: don't set nameservers for client

    The resolver is mainly useful for the ACME server, and acme.nix uses its
    own DNS server to test DNS-01 challenges.
    emilazy committed Apr 18, 2020
    Copy the full SHA
    21f183a View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2020

  1. Merge pull request #85503 from emilazy/acme-test-cleanups

    ACME test cleanups
    flokli committed Apr 19, 2020
    Copy the full SHA
    ab0da25 View commit details
    Browse the repository at this point in the history