-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
Comparing changes
Open a pull request
base repository: NixOS/nixpkgs
base: a88d17bc6934
head repository: NixOS/nixpkgs
compare: ab0da25762b9
- 7 commits
- 11 files changed
- 3 contributors
Commits on Apr 18, 2020
-
Also add myself to maintainers and correct meta.homepage.
Configuration menu - View commit details
-
Copy full SHA for 6285d5e - Browse repository at this point
Copy the full SHA 6285d5eView commit details -
nixos/tests/acme: don't restrict to x86_64
This was added in aade4e5, but the implementation of the ACME module has been entirely rewritten since then, and the test seems to run fine on AArch64.
Configuration menu - View commit details
-
Copy full SHA for 352e30d - Browse repository at this point
Copy the full SHA 352e30dView commit details -
nixos/tests/acme: use *.test domains
Shimming out the Let's Encrypt domain name to reuse client configuration doesn't work properly (Pebble uses different endpoint URL formats), is recommended against by upstream,[1] and is unnecessary now that the ACME module supports specifying an ACME server. This commit changes the tests to use the domain name acme.test instead, and renames the letsencrypt node to acme to reflect that it has nothing to do with the ACME server that Let's Encrypt runs. The imports are renamed for clarity: * nixos/tests/common/{letsencrypt => acme}/{common.nix => client} * nixos/tests/common/{letsencrypt => acme}/{default.nix => server} The test's other domain names are also adjusted to use *.test for consistency (and to avoid misuse of non-reserved domain names such as standalone.com). [1] letsencrypt/pebble#283 (comment) Co-authored-by: Yegor Timoshenko <yegortimoshenko@riseup.net>
Configuration menu - View commit details
-
Copy full SHA for d0f04c1 - Browse repository at this point
Copy the full SHA d0f04c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 695fd78 - Browse repository at this point
Copy the full SHA 695fd78View commit details -
nixos/tests/common/acme: enable Pebble strict mode
This lets us get early warning about any bugs or backwards-compatibility hazards in lego. Pebble will default to this in the future, but doesn't currently; see https://github.com/letsencrypt/pebble/blob/v2.3.0/README.md#strict-mode.
Configuration menu - View commit details
-
Copy full SHA for e6d5e83 - Browse repository at this point
Copy the full SHA e6d5e83View commit details -
nixos/tests/common/acme: don't set nameservers for client
The resolver is mainly useful for the ACME server, and acme.nix uses its own DNS server to test DNS-01 challenges.
Configuration menu - View commit details
-
Copy full SHA for 21f183a - Browse repository at this point
Copy the full SHA 21f183aView commit details
Commits on Apr 19, 2020
-
Merge pull request #85503 from emilazy/acme-test-cleanups
ACME test cleanups
Configuration menu - View commit details
-
Copy full SHA for ab0da25 - Browse repository at this point
Copy the full SHA ab0da25View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff a88d17bc6934...ab0da25762b9