Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add myself (turion) to the maintainers list for several packages #85548

Merged
merged 1 commit into from Apr 19, 2020

Conversation

turion
Copy link
Contributor

@turion turion commented Apr 19, 2020

Following nh2's advice, I want to be more involved in nixpkgs,
and I'll start to review changes to programs that are important to me,
and that didn't have a long list of maintainers yet.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Note: I got the feeling that nix-shell -p nixpkgs-review --run "nixpkgs-review wip" didn't do anything sensible. See the command line output:

$ nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
Von https://github.com/NixOS/nixpkgs
 + b57929a4fa1...d4d6d26588d master     -> refs/nixpkgs-review/0  (Aktualisierung erzwungen)
$ git worktree add /home/turion/.cache/nixpkgs-review/rev-f253da42f8fe2bf2d955849d9b4fff54e1a0f0d1-dirty/nixpkgs d4d6d26588de50957d8723b219007b0b35f346d5
Bereite Arbeitsverzeichnis vor (losgelöster HEAD d4d6d26588d)
Aktualisiere Dateien: 100% (21510/21510), Fertig.
HEAD ist jetzt bei d4d6d26588d Merge pull request #85458 from rnhmjoj/mitmproxy
$ nix-env -f /home/turion/.cache/nixpkgs-review/rev-f253da42f8fe2bf2d955849d9b4fff54e1a0f0d1-dirty/nixpkgs -qaP --xml --out-path --show-trace
No diff detected, stopping review...
$ git worktree prune

Following nh2's advice, I want to be more involved in nixpkgs,
and I'll start to review changes to programs that are important to me,
and that didn't have a long list of maintainers yet.
@nh2
Copy link
Contributor

nh2 commented Apr 19, 2020

@Ma27 Ma27 merged commit beb9b1a into NixOS:master Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants