Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

j: 807 -> 901 #85547

Merged
merged 1 commit into from Apr 20, 2020
Merged

j: 807 -> 901 #85547

merged 1 commit into from Apr 20, 2020

Conversation

AshyIsMe
Copy link
Contributor

Upgrade j to 901.
Uses the newer build scripts in the make2 directory in the jsource repo.

Motivation for this change

Update j to the latest stable release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Synthetica9 and 7c6f434c April 19, 2020 11:19
Synthetica9
Synthetica9 approved these changes Apr 19, 2020
View reviewed changes
Copy link
Member

@Synthetica9 Synthetica9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, seems to work

@AshyIsMe
j: 807 -> 901
0c454c4 
Upgrade j to 901.
Uses the newer build scripts in the make2 directory in the jsource repo.
@7c6f434c 7c6f434c merged commit 916aa56 into NixOS:master Apr 20, 2020
@AshyIsMe AshyIsMe deleted the j901 branch April 20, 2020 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Synthetica9 Synthetica9 Synthetica9 approved these changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AshyIsMe @Synthetica9 @7c6f434c @Janik-Haag