Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

whsniff: init #85573

Merged
merged 2 commits into from May 3, 2020
Merged

whsniff: init #85573

merged 2 commits into from May 3, 2020

Conversation

snicket2100
Copy link
Contributor

Motivation for this change

adding a new package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@snicket2100
Copy link
Contributor Author

labelled it as platforms.linux as I have no way to build it on Darwin... is this all right, or what's the alternative?

@snicket2100 snicket2100 marked this pull request as draft April 19, 2020 21:41
@snicket2100 snicket2100 marked this pull request as ready for review April 19, 2020 23:00
calbrecht
calbrecht approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@calbrecht calbrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build with nixpkgs-review pr and started whsniff in resulting shell.
LGTM, although i cannot tell if it does what it should, since i do not own a TI CC2531 USB Dongle :)

@snicket2100
Copy link
Contributor Author

:) I did test the binary myself with the dongle, works as expected!

@calbrecht
Copy link
Member

nixpkgs-review pr 85573
1 package built:
whsniff

jonringer
jonringer reviewed May 3, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the whsniff commit should be whisniff: init at 1.3

@snicket2100
Copy link
Contributor Author

the whsniff commit should be whisniff: init at 1.3

fixed! @jonringer

jonringer
jonringer approved these changes May 3, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 85573 1

1 package built: - whsniff

@jonringer jonringer merged commit e91183d into NixOS:master May 3, 2020
@snicket2100 snicket2100 deleted the whsniff-init branch May 4, 2020 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calbrecht calbrecht calbrecht approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@snicket2100 @calbrecht @jonringer