Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/licenses: use https where possible #85517

Merged
merged 1 commit into from Apr 19, 2020
Merged

lib/licenses: use https where possible #85517

merged 1 commit into from Apr 19, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Apr 18, 2020 •
edited

Motivation for this change

Let's use https for licenses

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak prusnak requested a review from alyssais as a code owner April 18, 2020 21:18
1000101
1000101 reviewed Apr 18, 2020
View reviewed changes
lib/licenses.nix Outdated Show resolved Hide resolved
@Ekleog
Copy link
Member

Ekleog commented Apr 19, 2020

Thank you! Manual testing reveals that two licenses are directing towards broken websites (eapl and amd), but trying the http version of them wasn't any better, so… meh.

Merging, if you feel motivated about fixing up the links and/or straight removing the licenses (if they aren't used anywhere in nixpkgs), feel free to submit a subsequent PR, it'd be great!

@Ekleog Ekleog merged commit 73d4b9c into NixOS:master Apr 19, 2020
@prusnak prusnak deleted the licenses branch April 20, 2020 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1000101 1000101 1000101 left review comments

@alyssais alyssais Awaiting requested review from alyssais alyssais is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prusnak @Ekleog @1000101