Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Improvements to libvirt #85562

Closed
wants to merge 6 commits into from
Closed

[WIP] Improvements to libvirt #85562

wants to merge 6 commits into from

Conversation

kmcopper
Copy link
Contributor

@kmcopper kmcopper commented Apr 19, 2020 •
edited

Motivation for this change

Use python3 for libvirt. Add myself as additional maintainer for libvirt.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fpletz @volth am I missing anything here in my rough first draft? Is this even something that is wanted?

@kmcopper kmcopper marked this pull request as ready for review April 19, 2020 14:12
@kmcopper kmcopper marked this pull request as draft April 19, 2020 14:15
@basvandijk basvandijk mentioned this pull request Sep 29, 2020
Merged
10 tasks
@teto teto mentioned this pull request Nov 10, 2020
Closed
10 tasks
@stale
Copy link

stale bot commented Jun 4, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 4, 2021
@siraben
Copy link
Member

siraben commented Jul 4, 2021

Closed by #113026

@siraben siraben closed this Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wedens wedens wedens left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 6.topic: python 8.has: module (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kmcopper @siraben @wedens @ryantm