Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blas: fix build on darwin #85582

Merged
merged 1 commit into from Apr 20, 2020
Merged

blas: fix build on darwin #85582

merged 1 commit into from Apr 20, 2020

Conversation

smaret
Copy link
Member

@smaret smaret commented Apr 19, 2020

Motivation for this change

Fix build on Darwin
See https://hydra.nixos.org/job/nixpkgs/trunk/blas.x86_64-darwin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Apr 19, 2020
@ofborg ofborg bot requested a review from ttuegel April 19, 2020 21:17
@smaret
Copy link
Member Author

smaret commented Apr 19, 2020

cc @matthewbauer

@marsam marsam merged commit 636a5a6 into NixOS:master Apr 20, 2020
@marsam
Copy link
Contributor

marsam commented Apr 20, 2020

Thanks!

@smaret smaret deleted the fix-blas-darwin branch April 20, 2020 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smaret @marsam