Skip to content

[20.03] pythonPackages.{namedlist, ludios_wpull}: mark broken only on Python 3.8 #85533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 22, 2020
Merged

[20.03] pythonPackages.{namedlist, ludios_wpull}: mark broken only on Python 3.8 #85533

merged 2 commits into from
Apr 22, 2020
+5 −3

Conversation

ivan
Copy link
Member

@ivan ivan commented Apr 19, 2020

Motivation for this change

This undoes some of 5fe104d - these libraries work fine on Python 3.7 and are used by grab-site.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ivan ivan requested review from FRidh and jonringer as code owners April 19, 2020 03:36
@ofborg ofborg bot added 6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 19, 2020
worldofpeace
worldofpeace suggested changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use disabled = isPy38?

@ivan ivan force-pushed the mark-some-unbroken branch from a519111 to a01e8f7 Compare April 22, 2020 05:28
@ivan
Copy link
Member Author

ivan commented Apr 22, 2020

@worldofpeace fixed, thanks.

FRidh
FRidh requested changes Apr 22, 2020
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disabled needs to be passed to buildPythonPackage, but not as part of meta.

ivan added 2 commits April 22, 2020 05:55
@ivan
pythonPackages.namedlist: unmark broken, mark disabled for Python 3.8

Verified

This commit was signed with the committer’s verified signature. The key has expired.
dtzWill Will Dietz
GPG key ID: EBB0EA4124809D02
Expired
Verified
Learn about vigilant mode
3f7a5cb 
https://nix-cache.s3.amazonaws.com/log/a4mdvyjbsy157i1v97rg6avp5a8inm0g-python3.8-namedlist-1.7.drv
@ivan
pythonPackages.ludios_wpull: unmark broken, mark disabled for Python 3.8

Verified

This commit was signed with the committer’s verified signature. The key has expired.
dtzWill Will Dietz
GPG key ID: EBB0EA4124809D02
Expired
Verified
Learn about vigilant mode
dd2570d 
ludios_wpull depends on namedlist, which currently has failing tests
on Python 3.8.
@ivan ivan force-pushed the mark-some-unbroken branch from a01e8f7 to dd2570d Compare April 22, 2020 05:57
@ivan
Copy link
Member Author

ivan commented Apr 22, 2020

@FRidh sorry about that, fixed, and tested the evals on Linux

@worldofpeace worldofpeace merged commit 95b9c99 into NixOS:release-20.03 Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

@worldofpeace worldofpeace

@jonringer jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivan @FRidh @worldofpeace