Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] pythonPackages.{namedlist, ludios_wpull}: mark broken only on Python 3.8 #85533

Merged
merged 2 commits into from Apr 22, 2020
Merged

[20.03] pythonPackages.{namedlist, ludios_wpull}: mark broken only on Python 3.8 #85533

merged 2 commits into from Apr 22, 2020

Conversation

ivan
Copy link
Member

@ivan ivan commented Apr 19, 2020

Motivation for this change

This undoes some of 5fe104d - these libraries work fine on Python 3.7 and are used by grab-site.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace suggested changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use disabled = isPy38?

@ivan
Copy link
Member Author

ivan commented Apr 22, 2020

@worldofpeace fixed, thanks.

FRidh
FRidh requested changes Apr 22, 2020
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disabled needs to be passed to buildPythonPackage, but not as part of meta.

@ivan
Copy link
Member Author

ivan commented Apr 22, 2020

@FRidh sorry about that, fixed, and tested the evals on Linux

@worldofpeace worldofpeace merged commit 95b9c99 into NixOS:release-20.03 Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

@worldofpeace worldofpeace worldofpeace requested changes

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivan @FRidh @worldofpeace