Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a17e021b9486
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 426646cc9bf0
Choose a head ref
  • 7 commits
  • 11 files changed
  • 2 contributors

Commits on Apr 19, 2020

  1. pebble: v2.2.2 -> v2.3.0 

    Also add myself to maintainers and correct meta.homepage.

(cherry picked from commit 6285d5e)
    @emilazy
    emilazy committed Apr 19, 2020
    Copy the full SHA
    e1c41b8 View commit details

  2. nixos/tests/common/acme: enable Pebble strict mode 

    This lets us get early warning about any bugs or backwards-compatibility
hazards in lego.

Pebble will default to this in the future, but doesn't currently;
see https://github.com/letsencrypt/pebble/blob/v2.3.0/README.md#strict-mode.

(cherry picked from commit e6d5e83)
    @emilazy
    emilazy committed Apr 19, 2020

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    dtzWill Will Dietz
    GPG key ID: EBB0EA4124809D02
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    b0d26e9 View commit details

  3. nixos/tests/acme: don't restrict to x86_64 

    This was added in aade4e5, but the
implementation of the ACME module has been entirely rewritten since
then, and the test seems to run fine on AArch64.

(cherry picked from commit 352e30d)
    @emilazy
    emilazy committed Apr 19, 2020
    Copy the full SHA
    8283094 View commit details

  4. nixos/tests/acme: use *.test domains 

    Shimming out the Let's Encrypt domain name to reuse client configuration
doesn't work properly (Pebble uses different endpoint URL formats), is
recommended against by upstream,[1] and is unnecessary now that the ACME
module supports specifying an ACME server. This commit changes the tests
to use the domain name acme.test instead, and renames the letsencrypt
node to acme to reflect that it has nothing to do with the ACME server
that Let's Encrypt runs. The imports are renamed for clarity:

* nixos/tests/common/{letsencrypt => acme}/{common.nix => client}
* nixos/tests/common/{letsencrypt => acme}/{default.nix => server}

The test's other domain names are also adjusted to use *.test for
consistency (and to avoid misuse of non-reserved domain names such
as standalone.com).

[1] letsencrypt/pebble#283 (comment)

Co-authored-by: Yegor Timoshenko <yegortimoshenko@riseup.net>
(cherry picked from commit d0f04c1)
    @emilazy
    emilazy committed Apr 19, 2020
    Copy the full SHA
    2b8100d View commit details

  5. nixos/tests/acme: use CAP_NET_BIND_SERVICE 

    (cherry picked from commit 695fd78)
    @emilazy
    emilazy committed Apr 19, 2020
    Copy the full SHA
    60e6ba6 View commit details

  6. nixos/tests/common/acme: don't set nameservers for client 

    The resolver is mainly useful for the ACME server, and acme.nix uses its
own DNS server to test DNS-01 challenges.

(cherry picked from commit 21f183a)
    @emilazy
    emilazy committed Apr 19, 2020
    Copy the full SHA
    f035e26 View commit details

  7. Merge pull request #85584 from emilazy/acme-test-cleanups-20.03 

    [20.03] ACME test cleanups
    @flokli
    flokli authored Apr 19, 2020
    Copy the full SHA
    426646c View commit details
Loading