Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux: bump stable versions (5.6.4 -> 5.6.5 & 5.5.17 -> 5.5.18) #85586

Merged
merged 8 commits into from Apr 20, 2020
Merged

linux: bump stable versions (5.6.4 -> 5.6.5 & 5.5.17 -> 5.5.18) #85586

merged 8 commits into from Apr 20, 2020

Conversation

kraem
Copy link
Member

@kraem kraem commented Apr 19, 2020 •
edited

Motivation for this change

Bumps stable versions 5.6.4 -> 5.6.5 and 5.5.17 -> 5.5.18.
5.6.5 built and booted successfully on my machine.

Ran pkgs/os-specific/linux/kernel/update.sh which brought in the commits with the patches. Please tell me if I did something wrong 馃憤

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kraem kraem changed the title linux: 5.6.4 -> 5.6.5 linux: bump stable versions (5.6.4 -> 5.6.5 & 5.5.17 -> 5.5.18) Apr 19, 2020
@kraem
Copy link
Member Author

kraem commented Apr 19, 2020

Ping @NeQuissimus. Wasn't able to add you as a reviewer.

emilazy
emilazy approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hardened patch updates look good to me, glad to see the script worked okay for someone else!

@NeQuissimus NeQuissimus merged commit 523fe98 into NixOS:master Apr 20, 2020
@NeQuissimus
Copy link
Member

Which parts of this need to be picked to release-20.03?

@kraem kraem deleted the kraem/linux-5.6.5 branch April 20, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilazy emilazy emilazy approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kraem @NeQuissimus @emilazy