Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/release-small: drop latestKernel.login #85577

Merged
merged 1 commit into from Apr 19, 2020
Merged

nixos/release-small: drop latestKernel.login #85577

merged 1 commit into from Apr 19, 2020

Conversation

lukateras
Copy link
Member

This partially reverts e133e39 and addresses #84522 (comment).

It seems to be reasonable to only test LTS kernel in -small channel.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lukateras lukateras requested review from dasJ and emilazy April 19, 2020 19:22
dasJ
dasJ approved these changes Apr 19, 2020
View reviewed changes
Copy link
Member

@dasJ dasJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @ajs124

@lukateras
Copy link
Member Author

I'll self-merge this once eval is complete.

emilazy
emilazy approved these changes Apr 19, 2020
View reviewed changes
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ajs124
Copy link
Member

ajs124 commented Apr 19, 2020

We should probably still fix the test though, shouldn't we?

@lukateras
Copy link
Member Author

@ajs124 It is working, it's just that it is not included in small jobset.

@lukateras lukateras merged commit d0bc63c into NixOS:master Apr 19, 2020
@lukateras lukateras deleted the 2020-04-19-no-latest-kernel-in-small-channel branch April 19, 2020 19:34
@dasJ
Copy link
Member

dasJ commented Apr 19, 2020

Well, Hydra is happy, and so am I {^_^}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasJ dasJ dasJ approved these changes

@emilazy emilazy emilazy approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lukateras @ajs124 @dasJ @emilazy