Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/howdoi #85579

Merged
merged 2 commits into from Apr 20, 2020
Merged

Fix/howdoi #85579

merged 2 commits into from Apr 20, 2020

Conversation

siriobalmelli
Copy link
Contributor

Motivation for this change

Wanted howdoi utility available in nix-env, but
nix-env -iA "nixpkgs.python37Packages.howdoi" was broken on both Darwin and Ubuntu due to missing dependencies on cachelib and appdirs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@siriobalmelli
howdoi: fix Darwin build dependencies
0e48a68 
Signed-off-by: Sirio Balmelli <sirio@b-ad.ch>
@siriobalmelli
howdoi: cachelib and appdirs dependencies _also_ needed for Linux.
85501ca 
Signed-off-by: Sirio Balmelli <sirio@b-ad.ch>
@ofborg ofborg bot requested a review from costrouc April 19, 2020 19:55
@Mic92
Copy link
Member

Mic92 commented Apr 19, 2020

@GrahamcOfBorg build nixpkgs.python37Packages.howdoi

@siriobalmelli siriobalmelli mentioned this pull request Apr 19, 2020
Merged
10 tasks
calbrecht
calbrecht approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@calbrecht calbrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran with nix-shell --pure. LGTM

@Mic92 Mic92 merged commit 216237e into NixOS:master Apr 20, 2020
@siriobalmelli siriobalmelli deleted the fix/howdoi branch April 20, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calbrecht calbrecht calbrecht approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@siriobalmelli @Mic92 @calbrecht