New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gopass: Add passAlias parameter to derivation #85521
Conversation
cc @andir |
@GrahamcOfBorg build gopass |
Looks good to me. Could you please make sure the reasoning you provided in the PR description is also in the commit? |
149b324
to
1ace99d
Compare
@andir done, rebased on latest |
@GrahamcOfBorg build gopass |
@@ -1,4 +1,11 @@ | |||
{ stdenv, buildGoModule, fetchFromGitHub, git, gnupg, xclip, wl-clipboard, installShellFiles, makeWrapper }: | |||
{ stdenv, makeWrapper | |||
, buildGoPackage, fetchFromGitHub, installShellFiles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You changed this here to buildGoPackage
but further down you are using buildGoModule
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, yes, that seems like a rebase artifact - the package was using buildGoPackage
before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it (and built locally as well this time :P)
Add a `passAlias` to `gopass` derivation, similarly to how there's `viAlias` parameter supported by vim/neovim derivations. Apart from convenience this is also necessary for e.g. making `docker-credential-helpers` work without patching the latter - the package uses `pass` executable from `PATH` https://github.com/docker/docker-credential-helpers/blob/f78081d1f7fef6ad74ad6b79368de6348386e591/pass/pass_linux.go#L67. By setting `passAlias` to `true` (e.g. via overlays like so: https://github.com/rvolosatovs/infrastructure/blob/94971f34db9df79b6666e626fa52840eb1fee840/nixpkgs/overlays.nix#L315-L317), secure Docker authentication via `gopass` "just works"™
1ace99d
to
ae19e15
Compare
@GrahamcOfBorg build gopass |
Motivation for this change
Add a
passAlias
togopass
derivation, similarly to how there'sviAlias
parameter supported by vim/neovim derivations.Apart from convenience this is also necessary for e.g. making
docker-credential-helpers
work without patching the latter - the package usespass
executable fromPATH
https://github.com/docker/docker-credential-helpers/blob/f78081d1f7fef6ad74ad6b79368de6348386e591/pass/pass_linux.go#L67. By settingpassAlias
totrue
(e.g. via overlays like so: https://github.com/rvolosatovs/infrastructure/blob/94971f34db9df79b6666e626fa52840eb1fee840/nixpkgs/overlays.nix#L315-L317), secure Docker authentication viagopass
"just works"™Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)