Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional docs for doJailBreak #85536

Closed
wants to merge 160 commits into from

Conversation

asheshambasta
Copy link
Contributor

@asheshambasta asheshambasta commented Apr 19, 2020

Motivation for this change

Yesterday with @infinisil on #nixos, he pointed me to: NixOS/jailbreak-cabal#7 after a good deal of time wrangling through a package to make it work.
The nix-build -K command, is very handy for debugging things like these, again I learnt from infinisil.
And after much experimenting and looking through, it turned out that jailbreaking wasn't working as expected, and its documentation could point it out to avoid future confusion.

Things done

Since this is only a minor change in the documentation, I believe there will be no impact.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jakubgs and others added 30 commits February 5, 2020 01:48
It introduces support for several additional Brother printers.

Signed-off-by: Jakub Sokołowski <jakub@status.im>
Since we select everything as a module, snd_hda_codec_ca0132 is built as
well. DSP loading is not enabled by default, but without it the
soundcard produces timeouts within ALSA and does not emit sound.
Explicitly enable the firmware loading to ensure Soundblaster
Z/Zx/ZxR/Recon devices can be used with NixOS.
The patch to enable this by default in the kernel is staged for 5.8.
tree-wide: Switch from gnome3.maintainers to lib.teams.gnome
fetchpatch can't be used here and fetchurl from GitHub
like in PR NixOS#82928 has the risk of breaking the hash later;
fortunately the patches aren't too large.

(cherry picked from commit 2071e3b)
pyca/pyopenssl#899 (comment)
The tests in python3.pkgs.pyopenssl succeed!
Fixing this problem we experienced is listed as the only major change:
https://www.openssl.org/news/openssl-1.1.1-notes.html
This contains at least golang/go#37807, which
currently causes some of our go binaries to just fail when booted with
older kernels.

See golang/go#37436 for context.
linux config: enable Creative Soundblaster DSP loading
Adding phases to preInstallPhases is not possible in preBuild since by that time, phases is already populated.
@asheshambasta asheshambasta changed the base branch from master to haskell-updates April 19, 2020 07:53
@asheshambasta
Copy link
Contributor Author

asheshambasta commented Apr 19, 2020

@cdepillabout Closing this PR and I'll open a fresh one as you said.
I did merge all changes in haskell-updates with my branch and changed the base branch to haskell-updates, but since this PR was created with the UI, I'm not sure I'm seeing expected behaviour here.

See #85537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment