Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tailscale: set a CacheDir in the systemd unit. #85598

Merged
merged 1 commit into from Apr 21, 2020
Merged

nixos/tailscale: set a CacheDir in the systemd unit. #85598

merged 1 commit into from Apr 21, 2020

Conversation

danderson
Copy link
Contributor

Motivation for this change

Mirroring change made upstream in: tailscale/tailscale@362d6af

Without this change, tailscaled drops some cache files in /.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danderson
Copy link
Contributor Author

@GrahamcOfBorg eval

@danderson
nixos/tailscale: set a CacheDir in the systemd unit.
cee5ddb 
Fixes a bug where tailscaled drops some files into / when CacheDir
is unset.

Signed-off-by: David Anderson <dave@natulte.net>
@flokli flokli merged commit c1a6e60 into NixOS:master Apr 21, 2020
@danderson danderson deleted the tailscale-fix-cachedir branch April 21, 2020 21:41
@danderson danderson restored the tailscale-fix-cachedir branch November 4, 2020 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli left review comments

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danderson @flokli