Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/https-dns-proxy: system level support for DNS over HTTPS #85599

Merged
merged 2 commits into from Mar 24, 2022
Merged

nixos/https-dns-proxy: system level support for DNS over HTTPS #85599

merged 2 commits into from Mar 24, 2022

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Further to #81365.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@NeQuissimus
Copy link
Member

Can this be merged?

@peterhoeg
Copy link
Member Author

There are some pending items from the linked PR that I haven't gotten around to fixing up yet.

@ryantm ryantm marked this pull request as draft October 23, 2020 03:01
@peterhoeg peterhoeg force-pushed the m/https-dns branch 2 times, most recently from 1ee6def to 4a0c198 Compare March 31, 2021 02:24
@peterhoeg peterhoeg changed the title nixos/https-dns-proxy: system level support for DNS over HTTPS [WIP] nixos/https-dns-proxy: system level support for DNS over HTTPS Apr 6, 2021
@peterhoeg peterhoeg marked this pull request as ready for review April 6, 2021 07:06
@peterhoeg
Copy link
Member Author

This is good to go @pvgoran & @vcunat. This PR addresses the issues raised by @Mic92 on #81365

@vcunat
Copy link
Member

vcunat commented Apr 6, 2021

I see no problem at a quick glance. The only idea is that from the big providers I'd probably personally prefer Quad9 as the first choice.

@peterhoeg
Copy link
Member Author

Didn't know of quad9, sure, added.

@NeQuissimus
Copy link
Member

LGTM. Is there an easy VM test we could provide?

@vcunat
Copy link
Member

vcunat commented Apr 6, 2021 •
edited

I guess you could configure some resolver service to serve DoH (only, e.g. services.kresd.listenDoH) and add some static hints to get content you can query, then add this proxy on top of it and try resolving the content through the proxy. EDIT: not sure how much it will guard against issues breaking real-life usage though.

@peterhoeg
Copy link
Member Author

peterhoeg commented Apr 7, 2021 via email

@stale
Copy link

stale bot commented Oct 12, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 12, 2021
@peterhoeg
Copy link
Member Author

Despite there being no tests, is everyone OK with merging this? As it's new functionality, there should be no regressions.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 23, 2022
@vcunat
Copy link
Member

vcunat commented Mar 23, 2022

I'm not against, just not interested.

@peterhoeg peterhoeg merged commit 39f24ef into NixOS:master Mar 24, 2022
@peterhoeg peterhoeg deleted the m/https-dns branch March 24, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @NeQuissimus @vcunat