rust: bootstrap from source #85542

progval · 2020-04-19T10:13:39Z

Motivation for this change

Fully building Rust from source instead of starting with a binary download.
Resolves #72606.

Things done

Added mrustc, a small compiler written in C++
Compile Rust 1.29 with mrustc (this is the latest version that mrustc can compile)
Add Rust 1.30.2, to 1.41.0, as each version 1.n is required to build version 1.(n+1)
Change the 1.42 derivation to build from the previous 1.41 derivation instead of rustc-binary

Discussion

I am not sure this is something you want in Nixpkgs; as it significantly increases the resources needed to build the latest Rust version.
The initial build of Rust 1.29 (by mrustc) requires 2.5GB in /build and 15GB of RAM and takes about 30 minutes on a modern x86 machine. Each subsequent build of Rust (by rustc) takes about 15 minutes.
Most of the build time (especially the first one) is spent in a single compilation unit, which is src/librustc/lib.rs, so it is not very parallel.

It also requires LLVM 7 and 8 for older Rust version, in addition to LLVM 9 for the current version. (Although all versions should support LLVM 7, if you want to reduce this.)

Tests

I tested building on x86_64 and master. I'm currently building the chain on x86_64 + staging but it's looking good so far (I'll update this text when it's done).
I'm also trying to test on aarch64, but it's taking forever as my test machine only has 4GB of RAM.

Checklist

pkgs/development/compilers/mrustc/bootstrap.nix

pkgs/development/compilers/mrustc/default.nix

pkgs/development/compilers/mrustc/minicargo.nix

andir

Very nice! Great work! 👍

I've attempted this once before but ran into issue building the first "real" rustc with mrustc.

I left a few comments on parts that did stick out to me. We are likely also going to have the whole bootstrap story around rustc. It is a fairly long bootstrap chain. Probably hours on modern computers. That being said: we totally should bootstrap more stuff without needing external binaries.

If we give this a bit more polishing this could probably go in.

pkgs/development/compilers/rust/1_29.nix

pkgs/development/compilers/rust/1_30.nix

andir · 2020-04-19T10:36:56Z

pkgs/development/compilers/rust/1_42.nix

-    aarch64-unknown-linux-gnu = "79ddfb5e2563d0ee09a567fbbe121a2aed3c3bc61255b2787f2dd42183a10f27";
-    i686-apple-darwin = "628134b3fbaf5c0e7a25bd9a2b8d25f6e68bb256c8b04a3332ec979f5a1cd339";
-    x86_64-apple-darwin = "b6504003ab70b11f278e0243a43ba9d6bf75e8ad6819b4058a2b6e3991cc8d7a";
+  bootstrapRustPackages = {


IIRC mrustc did not support all the platforms we wanted to support. We should perhaps use binary bootstrapping on all of those platforms that we can't use mrustc on.

andir · 2020-04-19T10:38:34Z

pkgs/development/compilers/rust/rustc.nix

 }:

 let
  inherit (stdenv.lib) optionals optional optionalString;
  inherit (darwin.apple_sdk.frameworks) Security;

-  llvmSharedForBuild = pkgsBuildBuild.llvm_9.override { enableSharedLibraries = true; };


I do not think this change here is wise. This likely breaks cross-compilation.

hmm indeed, I didn't notice this. Should I replace this with a "selector" function, like pkgs: pkgs.llvm_7?

I am not entirely sure I can see what you are saying. Can you draft an example here?

https://gist.github.com/ProgVal/da945eab4ec04f55123411b4063de001

It's a pattern I noticed these files already use (selectRustPackage)

andir · 2020-04-19T10:44:00Z

@progval

I'm also trying to test on aarch64, but it's taking forever as my test machine only has 4GB of RAM.

We have a larger aarch64 community builder that you can use for such purposes: https://github.com/nix-community/aarch64-build-box

andir · 2020-04-19T10:45:23Z

I added @alyssais to reviewers as we had previous conversations about this topic. I expect they might have something to add/own experiences to share.

progval · 2020-04-19T10:50:02Z

I've attempted this once before but ran into issue building the first "real" rustc with mrustc.

At first I tried being more modular; by replacing most of mrustc's makefiles with nix expressions; but it ended up as a complete mess that didn't even work because multiple .so and .rlib paths were conflicting with each other, causing either missing files, wrong rust version or "possibly newer crate" errors. Was this your issue too?

andir · 2020-04-19T10:56:09Z

I've attempted this once before but ran into issue building the first "real" rustc with mrustc.

At first I tried being more modular; by replacing all of mrustc's makefiles with nix expressions; but it ended up as a complete mess that didn't even work because .so and .rlib paths were conflicting with each other. Was this your issue too?

No, I did the last attempt during December and IIRC this issue contains most of my story: thepowersgang/mrustc#132

alyssais

This is amazing! I’m so excited for it!

pkgs/development/compilers/mrustc/patches/0001-use-shared-mrustc-minicargo.patch

pkgs/development/compilers/mrustc/bootstrap.nix

alyssais · 2020-04-19T12:02:31Z

My experience was basically the same — I didn’t get very far.

andir · 2020-04-19T13:04:40Z

I just gave this a shot on aarch64 and ran into this:
https://gist.github.com/andir/9ff79f180e1c24d6be474a1c755b542f

r-burns · 2021-02-16T04:37:08Z

Would anyone object if I rebased and separately submitted the mrustc init commit? It seems like there are still some open questions here about the bootstrapping, but maybe we can save the mrustc nix expression from bitrot and work on darwin support in the meantime.

r-burns · 2021-02-20T19:57:43Z

ping #113817

KamilaBorowska · 2021-04-04T18:42:40Z

Worth noting that mrustc was updated to support bootstrapping Rust 1.39: https://github.com/thepowersgang/mrustc/.

progval · 2021-04-04T18:44:02Z

I'm working on a patch on top of #113817 to support it

siraben · 2021-07-26T16:30:32Z

Does this PR still need to stay open?

siraben · 2021-07-26T16:31:22Z

Also, you might be interested in #123095 which is about bootstrapping the trusted binary seed fully from source (down from an 130 MB uncompressed tarball).

r-burns · 2021-09-01T01:07:47Z

I wonder if we can avoid the full stage2 bootstrap for each intermediate rustc binary - i.e. use x.py build instead of x.py dist so that we build each rustcN+1 using a rustcN which was built by rustcN-1. In theory this could cut the build time of each rustc in the bootstrap chain by 50%, because only stage1 would be built. However, rustc documentation hints that there may be ABI issues, so I'd have to test it out to see if it works.

https://rustc-dev-guide.rust-lang.org/building/bootstrapping.html#stages-of-bootstrapping

Mic92 · 2021-09-02T06:58:52Z

Even half the bootstrap chain is still too much in my opinion.

Ericson2314 · 2021-09-05T15:44:29Z

I still don't see the problem of just adding this as a separate way of building rust, with the goal using it to create the bootstrap binaries. That doesn't wreck rebuild critical path length. What's the problem then?

stale · 2022-04-18T17:16:06Z

I marked this as stale due to inactivity. → More info

06kellyjac · 2022-04-18T20:00:00Z

Still important.

mrustc got closer to latest but there have been some more releases since.

nixos-discourse · 2023-08-08T00:15:39Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/where-did-you-get-stuck-in-the-nix-ecosystem-tell-me-your-story/31415/6

Atemu · 2024-12-21T08:05:45Z

That's not a reason to close this. The interesting part of this PR is actually using it to bootstrap rust, not the package itself.

I'm going to mark this as a draft though as this hasn't seen activity in a while and needs broader consensus and/or more confidence in mrustc's ability to keep up with upstream rust so that we don't need to have an insanely long bootstrap chain with dozens of rustcs.

Edit: Was a draft anyways.

progval requested review from andir, LnL7 and Mic92 as code owners April 19, 2020 10:13

ofborg bot added the 6.topic: rust label Apr 19, 2020

prusnak requested changes Apr 19, 2020

View reviewed changes

andir requested changes Apr 19, 2020

View reviewed changes

progval force-pushed the rust-source-bootstrap branch from 0fe3747 to 0b9697e Compare April 19, 2020 10:42

andir requested a review from alyssais April 19, 2020 10:44

progval force-pushed the rust-source-bootstrap branch from 0b9697e to 5bc3d80 Compare April 19, 2020 10:51

progval force-pushed the rust-source-bootstrap branch from 5bc3d80 to 95a888f Compare April 19, 2020 10:59

ofborg bot added the 8.has: package (new) label Apr 19, 2020

ofborg bot requested review from madjar, retrry, globin and cstrahan April 19, 2020 11:05

ofborg bot added 10.rebuild-darwin: 501+ 10.rebuild-darwin: 501-1000 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500 labels Apr 19, 2020

progval force-pushed the rust-source-bootstrap branch from 95a888f to 0d48bb8 Compare April 19, 2020 11:14

alyssais reviewed Apr 19, 2020

View reviewed changes

pkgs/development/compilers/mrustc/patches/0001-use-shared-mrustc-minicargo.patch Show resolved Hide resolved

pkgs/development/compilers/mrustc/bootstrap.nix Outdated Show resolved Hide resolved

progval added 2 commits April 19, 2020 14:07

mrustc: init at 0.9

c214df6

rust: bootstrap from source using mrustc

c27a821

progval force-pushed the rust-source-bootstrap branch from 0d48bb8 to c27a821 Compare April 19, 2020 12:07

progval mentioned this pull request Sep 11, 2020

add @progval as trusted user NixOS/aarch64-build-box#95

Closed

3 tasks

r-burns mentioned this pull request Feb 20, 2021

mrustc: init at 0.9 #113817

Merged

10 tasks

lopsided98 mentioned this pull request Sep 1, 2021

AdoptOpenJDK should build from source #136308

Closed

stale bot added the 2.status: stale label Apr 18, 2022

stale bot removed the 2.status: stale label Apr 18, 2022

stale bot added the 2.status: stale label Nov 2, 2022

stale bot removed the 2.status: stale label Aug 8, 2023

wegank added the 2.status: stale label Mar 19, 2024

wegank marked this pull request as draft March 20, 2024 15:40

lukateras removed request for cstrahan, retrry and lukateras December 15, 2024 20:42

ghost closed this Dec 21, 2024

Atemu reopened this Dec 21, 2024

github-actions bot added the 8.has: maintainer-list (update) label Dec 21, 2024

stale bot removed the 2.status: stale label Dec 21, 2024

wegank added the 2.status: stale label Jan 1, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rust: bootstrap from source #85542

rust: bootstrap from source #85542

progval commented Apr 19, 2020 •

edited

Loading

andir left a comment

andir Apr 19, 2020

andir Apr 19, 2020

progval Apr 19, 2020

andir Apr 19, 2020

progval Apr 19, 2020

andir commented Apr 19, 2020

andir commented Apr 19, 2020

progval commented Apr 19, 2020 •

edited

Loading

andir commented Apr 19, 2020

alyssais left a comment

alyssais commented Apr 19, 2020

andir commented Apr 19, 2020

r-burns commented Feb 16, 2021

r-burns commented Feb 20, 2021

KamilaBorowska commented Apr 4, 2021

progval commented Apr 4, 2021

siraben commented Jul 26, 2021

siraben commented Jul 26, 2021

r-burns commented Sep 1, 2021

Mic92 commented Sep 2, 2021 •

edited

Loading

Ericson2314 commented Sep 5, 2021

stale bot commented Apr 18, 2022

06kellyjac commented Apr 18, 2022

nixos-discourse commented Aug 8, 2023

Atemu commented Dec 21, 2024 •

edited

Loading

rust: bootstrap from source #85542

Are you sure you want to change the base?

rust: bootstrap from source #85542

Conversation

progval commented Apr 19, 2020 • edited Loading

Motivation for this change

Things done

Discussion

Tests

Checklist

andir left a comment

Choose a reason for hiding this comment

andir Apr 19, 2020

Choose a reason for hiding this comment

andir Apr 19, 2020

Choose a reason for hiding this comment

progval Apr 19, 2020

Choose a reason for hiding this comment

andir Apr 19, 2020

Choose a reason for hiding this comment

progval Apr 19, 2020

Choose a reason for hiding this comment

andir commented Apr 19, 2020

andir commented Apr 19, 2020

progval commented Apr 19, 2020 • edited Loading

andir commented Apr 19, 2020

alyssais left a comment

Choose a reason for hiding this comment

alyssais commented Apr 19, 2020

andir commented Apr 19, 2020

r-burns commented Feb 16, 2021

r-burns commented Feb 20, 2021

KamilaBorowska commented Apr 4, 2021

progval commented Apr 4, 2021

siraben commented Jul 26, 2021

siraben commented Jul 26, 2021

r-burns commented Sep 1, 2021

Mic92 commented Sep 2, 2021 • edited Loading

Ericson2314 commented Sep 5, 2021

stale bot commented Apr 18, 2022

06kellyjac commented Apr 18, 2022

nixos-discourse commented Aug 8, 2023

Atemu commented Dec 21, 2024 • edited Loading

progval commented Apr 19, 2020 •

edited

Loading

progval commented Apr 19, 2020 •

edited

Loading

Mic92 commented Sep 2, 2021 •

edited

Loading

Atemu commented Dec 21, 2024 •

edited

Loading