Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtualbox: 6.1.4 -> 6.1.6 #85556

Merged
merged 2 commits into from Apr 24, 2020
Merged

virtualbox: 6.1.4 -> 6.1.6 #85556

merged 2 commits into from Apr 24, 2020

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Apr 19, 2020

Motivation for this change

Fix kernel module build with linux 5.6.

Fixes: #84586

Things done

The tests are currently broken and I don't have the time to fix them.
It looks like the Virtualbox VM's in the tests start booting, but the kernel never reaches the init script.

Booting a VM (Windows and Linux) under NixOS with Linux 5.6 worked for me.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@B4dM4n B4dM4n mentioned this pull request Apr 19, 2020
Merged
10 tasks
@flokli
Copy link
Contributor

flokli commented Apr 19, 2020

@B4dM4n were the tests already broken before? In any case, could you mark them as broken?

@flokli
Copy link
Contributor

flokli commented Apr 19, 2020

It'd be really nice if you or some of the other regular contributors could find some time to port the tests to python and fix them. It's a pity they don't work currently - they automated a lot of testing and very often uncovered some (even upstream) bugs.

cc @wkral @ambrop72 @knedlsepp @grahamc

@Lucus16
Copy link
Contributor

Lucus16 commented Apr 23, 2020

I'm trying to debug the tests, findings so far:
/tmp/.vbox-*-ipc/ does not exist due to /tmp does not have sticky bit set

@Lucus16
Copy link
Contributor

Lucus16 commented Apr 23, 2020

In retrospect, that may be some unrelated bug that only occurs on my system, although that's still weird.

@flokli
Copy link
Contributor

flokli commented Apr 24, 2020

Let's merge this in, the tests were already broken before.

@flokli flokli merged commit 0d99474 into NixOS:master Apr 24, 2020
@flokli flokli mentioned this pull request Apr 24, 2020
Merged
10 tasks
@winterdeaf winterdeaf mentioned this pull request Apr 24, 2020
Merged
10 tasks
@B4dM4n B4dM4n deleted the virtualbox-616 branch April 25, 2020 14:12
@jcumming
Copy link
Contributor

jcumming commented May 4, 2020 •
edited

Build fails with hardening disabled, will try with hardening enabled..

kBuild: Linking SSMStandalone                                                                      
Error! Cannot find file '/build/VirtualBox-6.1.6/out/linux.amd64/release/obj/VBoxPcBios32/pci32.obj'

@jcumming
Copy link
Contributor

jcumming commented May 4, 2020

Fails with hardening enabled, too. :(

I'll try and figure out what I broke...

@flokli
Copy link
Contributor

flokli commented May 5, 2020

@jcumming I can build virtualbox, virtualboxWithExtpack and virtualboxHardened from latest master 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svanderburg svanderburg Awaiting requested review from svanderburg

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

virtualbox kernel drivers broken on latest master with latest kernel
4 participants
@B4dM4n @flokli @Lucus16 @jcumming