Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keepassxc: 2.5.2 -> 2.5.4 #85558

Merged
merged 1 commit into from Apr 19, 2020
Merged

keepassxc: 2.5.2 -> 2.5.4 #85558

merged 1 commit into from Apr 19, 2020
+18 −6

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Apr 19, 2020 •
edited

Motivation for this change

Changelog: https://github.com/keepassxreboot/keepassxc/releases/tag/2.5.4

  • disabled testcli flaky test
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak
keepassxc: 2.5.2 -> 2.5.4
e353fe8 
+ disabled testcli flaky test
@prusnak
Copy link
Member Author

prusnak commented Apr 19, 2020

Supersedes #79535

@prusnak prusnak mentioned this pull request Apr 19, 2020
Closed
@ofborg ofborg bot requested a review from jonafato April 19, 2020 12:57
jokogr
jokogr approved these changes Apr 19, 2020
View reviewed changes
Copy link
Contributor

@jokogr jokogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review pr 85558 and then ./results/keepassxc/Applications/KeePassXC.app/Contents/MacOS/KeePassXC works on my MacBook.

@ajs124 ajs124 mentioned this pull request Apr 19, 2020
Closed
10 tasks
@Ma27 Ma27 merged commit 07d6222 into NixOS:master Apr 19, 2020
@prusnak prusnak deleted the keepassxc branch April 20, 2020 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jokogr jokogr jokogr approved these changes

@jonafato jonafato Awaiting requested review from jonafato

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prusnak @jokogr @Ma27